Files
ElyOffice/tasks/reviews/M-12-r1.md
T
ZacharyZhang-NYandClaude Opus 5.5 0d4dd64640 Web pages: browsers are made at once, so none outlives its view (M-12)
make_browsers creates each browser synchronously and adopts it in the
same call, so no view waits on a browser: it leaves before creation
(skipped) or has a browser to close. The late-close branch in
on_after_created is gone. webprobe drops 5 views before the pump and
10 within 27 ms; webview.sh wants all 35 freed before the hold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 13:47:45 -04:00

902 B

FAIL

crates/ely-web-content/src/handlers.rs:347 — Missing regression coverage for M-12. No retained test closes a view after browser creation is submitted but before on_after_created; the existing webprobe churn closes only after Event::Loaded. Removing the entire surface.closed branch in a review copy leaves all nine WSL library tests passing, while real CEF probes on Windows and WSL reproduce the retained browser/surface on the first such close (the current implementation passes 20 cycles). The original PERF-08 leak can therefore return undetected. Add a regression exercising the production Drop, late creation callback and deferred close, asserting forced browser closure and release of the surface; verify it fails when this branch is removed. Evidence: .work/m12-r1/linux-mutant-repository.log, .work/m12-r1/windows-native-mutant.log, .work/m12-r1/linux-native-mutant.log.