ElyOffice/tasks/reviews/R4.1-r2.md

FAIL

1. ../Ely-GPUI-Components/src/menus/draw.rs:181 — A pointer move after an icon button closes the menu can crash the application. Click Paste, then move the pointer over that button before the next repaint. Open::close has emptied levels, but the old mouse-move handler treats the missing level as a different selection and calls mark, which indexes levels[0] at menu.rs:157. The runtime probe reproduced an index-out-of-bounds panic with two consecutive window events and no intervening paint. Ignore events whose menu level no longer exists, as ordinary menu rows already do, and add this event-order regression.

2. ../Ely-GPUI-Components/src/menus/menu.rs:38 — The round-one selection-invalidation fix still executes another command when a removed button has a successor. In a Cut / Paste / Delete row, highlight Paste, then remove Paste while the menu stays open. Delete shifts into the same column, passes runs, and Enter executes Delete without the user selecting it; the runtime probe recorded ["delete"]. Validate the highlighted command's identity, or clear the mark when the row's membership changes, and require explicit navigation before executing again. Add a regression for removing a middle button; the committed test only truncates the row.