ElyOffice/tasks/reviews/R4.10-r2.md

FAIL

1. apps/ely-mark/src/export/copy.rs:74 — [P2] A pending conversion overwrites a newer clipboard operation. Start Copy as HTML Code, then use Copy as Markdown or ordinary Ctrl+C before conversion finishes: the newer copy lands correctly, but the old task subsequently replaces it with HTML. Only the three converted-copy actions replace Desk::copying; the other copy routes leave it alive. Invalidate pending conversions for later clipboard writes, or reject completion when a newer clipboard operation has occurred. Both window-dispatched probes fail after the pending conversion completes, while their immediate clipboard assertions pass. Evidence: .work/R4.10/review-r2/copy-probes.log.

2. C:/Users/zhang/Documents/Github/Ely-GPUI-Components/src/documents/document/point.rs:294 — [P2] The new drawn_link lookup is quadratic: it calls source_at for successive displayed characters, repeatedly decoding and aligning the same source span. Right-click near the beginning of an open plain-text paragraph and the menu waits for this lookup even when there are no links. For 2,000, 4,000 and 8,000 characters, target_at took 99 ms, 491 ms and 1.94 s respectively in the unoptimized build; parsing, walking and Reader together stayed below 1 ms. This introduces slow ordinary-click feedback contrary to PERF-02. Resolve the source-to-display position without repeatedly scanning the span, and cover paragraph-length scaling. Evidence: .work/R4.10/review-r2/target-cost.log and parse-baseline.log.

3. C:/Users/zhang/Documents/Github/Ely-GPUI-Components/src/documents/document/point.rs:179 — [P2] Overlapping right presses can publish their targets in reverse order. In an open block containing [one](https://a.test) [two](https://b.test), select both links, then right-click one and two while the first lookup is pending. Both requests retain identical text/selection snapshots, so the guard accepts both completions. The probe observed b.test followed by a.test; ElyMark therefore replaces the latest menu with the older link target, making Open Link and Copy Link Address use the wrong address. Track the latest press or cancel superseded lookups, and emit only its target. Evidence: .work/R4.10/review-r2/latest-press.log.