Files
ElyOffice/tasks/reviews/R4.8-r3.md
T
2026-10-14 15:56:47 -04:00

1.1 KiB

FAIL

  1. C:/Users/zhang/Documents/Github/Ely-GPUI-Components/src/documents/document/block.rs:266 — line_end now returns an offset before a caret inside CRLF, but block-command callers still slice from the original caret. Open Intro\r\nNext\r\n in Source mode, focus the editor, press End, then call MarkdownDocument::block(BlockCommand::CodeBlock): the caret is byte 6, line_end returns 5, and block/split.rs:53 panics with byte range starts at 6 but ends at 5. End followed by Shift+Right and the same command also panics, at block/insert.rs:31. Rule, MathBlock, Toc, Footnote and LinkDefinition share the first failure. Both public interaction probes pass with 07fee55's helpers and fail with ce015e7, so this regresses completed block commands (MARK-15). Normalize the actual caret/selection offsets consistently before deriving and slicing ranges, preserving the decision to leave the editor's CRLF model unchanged, and cover these End-key interactions. Evidence: .work/R4.8-r3-review/probes.log, baseline-blocks.log, baseline-matrix.log and probe-source.log.