ElyOffice/tasks/reviews/R4.9-r2.md

FAIL

1. apps/ely-mark/src/tools.rs:85 — Delete Table loses document focus in visual mode, breaking MARK-15's keyboard undo. Open the table between before and after in blocks/menus.rs:66 by clicking it, choose Paragraph → Table → Delete Table, then press Ctrl+Z: the table stays deleted. The asynchronous edit closes the block's input, and focus falls to Desk instead of the document, so Undo never reaches its handler. Explicitly restoring document focus makes Ctrl+Z restore the table. Preserve a live document focus target when deletion removes the open input, and cover visual-mode menu deletion and undo; the submitted test switches to Source mode. Evidence: .work/R4.9-r2/linux-probes-confirm.log.

2. apps/ely-mark/src/blocks/tests.rs:3 — Round 1 finding 4 is not fully fixed: Action remains imported unconditionally, although its only uses are now Windows-gated. On Linux, cargo clippy -p ely-mark --all-targets --locked -- -D warnings fails with unused import: Action. Gate the import with its users, or qualify the type inside the Windows-only code. Evidence: .work/R4.9-r2/linux-clippy.log.

3. apps/ely-mark/src/blocks/menus.rs:24 — All three new menu tests run on macOS but assume an in-window MenuBar below the title bar. The macOS implementation of crates/ely-ui/src/shell/mod.rs:82 returns None; setting GPUI's menus does not create that test target. The simulated click and arrow/Enter events therefore reach other content, and the assertions fail. Selecting that existing macOS shell branch in the isolated Linux copy reproduces all three failures; this was not a native macOS run. Restrict these interaction tests to platforms that draw this bar, or give the tests an explicit MenuBar harness. Evidence: .work/R4.9-r2/mac-menu-branch-probe.log.

4. ../Ely-GPUI-Components/src/documents/document/tables.rs:167 — This new comment and the new comment at src/documents/document/tests/lend.rs:15 each contain 12 words, exceeding the explicit ten-word limit. The application's passing comments.py does not scan the sibling component repository, so it misses both additions. Shorten or remove them. Evidence: .work/R4.9-r2/component-comments.log.