ZacharyZhang-NYandClaude Opus 5.5
87886c8a8d
Grid and header menus share ely_office::menu with ElyDoc. Each item's availability is the kernel's state for the exact command it runs (patch 0045). Patch 0046 lets a header select its row or column while a shape is selected or its text is edited: the view shell ends the drawing edit, keeps the typed text, leaves drawing mode, then marks. Ely no longer sends Esc first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1.1 KiB
FAIL
apps/ely-table/src/menu.rs:150 — [P2] Header menus enable every action unconditionally, violating R5.5's requirement that availability come from the kernel. Protect a sheet with only selection allowed, then right-click a row header: Insert, Delete, Cut and Clear Contents remain enabled. The kernel disables those operations, and choosing Delete produces rows.delete: the undo history did not move instead of an unavailable menu item. Reproduced against the rebuilt worker; see .work/R5.5-r1-review/kernel-probe.log. Obtain authoritative availability after the header selection settles, store it with the menu offer, and test protected row and column headers instead of treating all header actions as enabled.
crates/ely-office/src/menu.rs:1 — [P3] Six new comments exceed the explicit ten-word limit: this file's lines 1, 33, 50 and 69, and apps/ely-table/src/menu.rs:155 and :186. Running python tests/scripts/comments.py exits with failure on precisely these six comments (.work/R5.5-r1-review/comments.log). Shorten or remove them so the repository's required comment check passes.