Files
ElyOffice/tasks/reviews/R5.5-r2.md
T
ZacharyZhang-NYandClaude Opus 5.5 87886c8a8d R5.5: ElyTable right-click menus, Excel-style; three rounds used, last fixes tested
Grid and header menus share ely_office::menu with ElyDoc. Each item's
availability is the kernel's state for the exact command it runs
(patch 0045). Patch 0046 lets a header select its row or column while
a shape is selected or its text is edited: the view shell ends the
drawing edit, keeps the typed text, leaves drawing mode, then marks.
Ely no longer sends Esc first.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-14 13:02:10 -04:00

1.4 KiB

FAIL

apps/ely-table/src/menu.rs:199 — [P2] Requesting a header menu by right-clicking the first displayed cell also hit-tests drawing objects. Place a rectangle over the top-left cells, then right-click an affected row or column header: the synthetic click returns Target::Object, and offer_menu rejects it at line 178, showing an engine error instead of the header menu. Both header kinds fail through the application event path (.work/R5.5-r2-review/ui-probe.log); the rebuilt-worker probe confirms the object target. Obtain header availability without hitting or selecting overlaid objects, preserve the row/column selection, and add regression coverage for covered headers.

apps/ely-table/src/menu.rs:117 — [P2] Row and column insertion use .uno:InsertCell availability, which differs from the commands they execute on protected sheets. Protect a sheet with selection and Insert Rows allowed, then right-click a row header: insertion is disabled although rows.insert_above succeeds. Insert Columns has the same failure. Both application probes fail; the rebuilt-worker probe reports InsertCell=false followed by successful insertion (.work/R5.5-r2-review/kernel-probe.log). Gate insertion with authoritative availability for the actual row/column commands, exposing that kernel state through the menu interface as needed, and test protection that explicitly permits each insertion.