Files
ElyOffice/tasks/reviews/R5.6-r2.md
T
ZacharyZhang-NYandClaude Opus 5.5 35a7bbb904 R5.6: ElyShow right-click menus, PowerPoint-style; Impress table borders drag; R3 PASS
The canvas offers Ely's menu by target: slide (layouts, comment), text
(bullets, numbering, comment), shape or text box, picture (replace,
crop), table (insert, delete, merge), each item gated by the kernel's
state for its own command. Impress's table borders read as text and
drag through R5.3's path; patch 0047 reports every edge's bounds and
makes the left edge drag. A line past its bound never moves against
the drag, so a still press sends nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-14 14:26:27 -04:00

953 B
Raw Blame History

FAIL

  • [P2] crates/ely-lok/src/view/borders.rs:112 — Inner Impress borders still subtract Writer's 40-twip gap from the kernel's maximum, which already accounts for the neighbouring column's minimum width. In a 2×2 table, shrink the rightmost column to its minimum, then press and release the inner divider without moving it. The kernel reports position = max = 3996 and the right edge at 4166; clamp(..., 0) returns -40, so drop_border sends a resize instead of treating the click as a no-op. The kernel moves the divider to 3956 and adds an undo step. Apply Impress's reported inner bounds directly, retain the Writer gap only where required, and add a regression for a stationary divider beside a minimum-width column. Reproduced with the rebuilt worker and SAL_DISABLE_OPENCL=1; the failing assertion and resulting geometry are in .work/R5.6-r2-stationary-probe.log (probe source retained in .work/R5.6-r2-probe-source.log).