Files
ElyOffice/tasks/reviews/R6.1-r2.md
T
2026-10-15 01:41:47 -04:00

2.2 KiB

FAIL

  1. reference/Ely-GPUI-Components/src/documents/document/cells.rs:164 — [P2] kept doubles every odd trailing backslash, including unchanged source whose existing padding already protects the separator. Open the first cell of | a\ | b |\n| --- | --- |\n| c | d |\n, then switch to Source without typing: a\ becomes a\\. Merely opening and switching modes therefore rewrites the file, violating PRD §14.3. Preserve unchanged cell bytes and account for the retained suffix when protecting a separator; add no-edit commit/mode-switch regressions alongside the compact-cell backslash test. review_probe_untouched_trailing_slash_preserves_source fails in .work/R6.1-r2/probes-expanded.log.

  2. reference/Ely-GPUI-Components/src/documents/document/lists.rs:241 — [P2] Moving between cells calls open on the same block, but open loses that block when the committed cell includes its starting byte (document/edit.rs:87). In the valid table alpha | beta\n--- | ---\nc | d\n, open alpha, type X, then press Tab or click beta: alphaX is committed, but no cell remains open. This breaks R6.1's cell navigation and click-to-edit behavior for tables without a leading pipe. Preserve the table's identity across a write to its first cell instead of treating its replaced start as a missing block. Add both navigation regressions; review_probe_tab_after_unprefixed_header_edit and review_probe_neighbor_click_after_unprefixed_header_edit fail in .work/R6.1-r2/probes-expanded.log, while the no-edit control passes.

  3. reference/Ely-GPUI-Components/src/documents/render/table.rs:64 — [P2] The new stop-propagation handlers cover the entire active cell, including padding outside its input, and discard those presses. Open alpha, place the caret after its first character, then click the cell's blank padding: the caret stays at 1 instead of moving to 5 as R6.1 requires. Right-clicking the same padding emits no DocumentEvent::Pointed, so ElyMark also opens no context menu (MARK-16). Route padding presses to the active cell's end and right-click target while keeping input presses within the existing transaction. Both padding probes fail in .work/R6.1-r2/probes-expanded.log.