Files
ElyOffice/tasks/reviews/R6.6-r2.md
T
ZacharyZhang-NYandClaude Opus 5.5 a316a5481a R6.6 round 2 fix: Git lookup tests use only temp folders
The lookup is split from the developer fallback, so the tests
need no built Git and check NoGit explicitly. Shorter stage.sh comment.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-15 12:37:20 -04:00

964 B

FAIL

  • crates/ely-platform/src/git.rs:143 — The revised sibling-bundle test now requires an actual development Git before creating its Git fixture. In a clean checkout without the ignored engines/git directory, cargo test --locked -p ely-platform --lib git::tests -- --test-threads=1 panics at expect("the built Git") with NotFound/NoGit on both Windows and Linux. Independent builds of 8580aed reproduce this (.work/R6.6-r2/windows-clean-git-tests.log, linux-clean-git-tests.log); supplying a built-Git fixture makes the test pass. Make the sibling lookup test independent of developer engine artifacts and cover the missing-provider result explicitly.

  • packaging/stage.sh:67 — The new comment contains 11 words, exceeding agents.md's ten-word limit. Running the repository comment checker against only this change's six source/script files exits 1 on this line (.work/R6.6-r2/scoped-comments.log). Shorten the comment to ten words or fewer.