§9 acceptance: grep-zero sweep — every internal x.ai/grok identifier renamed
The PRD's first acceptance gate now holds: grep -RinE '\bx\.ai\b|grok' crates/ --include='*.rs' → 0 matches (exempt: NOTICE and third-party license archives, README provenance, and the required 'Based on Grok Build Open Source' attribution, now sourced from version_attribution.txt). Wire-visible renames (both sides in this repo, changed in lockstep): - Auth method id 'grok.com' → 'kimi-code' (AuthMethodKind::KimiCode). - Every x.ai/* and _x.ai/* ACP ext method and meta key → kigi/* / _kigi/* (~200 names; grokShell → kigiShell). Session-file replay keeps a read-side alias for the legacy '_x.ai/session/update' method so existing updates.jsonl histories load; writes emit only the new name (both directions test-pinned). - Agent types grok-build* → kigi* with a documented legacy-prefix alias at resolution time so persisted sessions keep resolving. - ToolNamespace/BuiltinAgentName GrokBuild* → Kigi* (wire snake_case kigi/kigi_concise/kigi_hashline; schema regenerated); grok_build implementation dirs renamed to kigi*. - x-grok-* headers → x-kigi-*, __GROK_* sentinels → __KIGI_*, themes grokday/groknight → kigiday/kiginight (old persisted values fall back to the default theme), web_fetch allowlist xAI hosts → kimi.com + moonshot platforms, changelog CDN → this repo, grok-build changelog archives deleted. - BYOK default endpoint removed: [endpoints] api_base_url is now truly optional with NO default — consumers fail fast with the flag name when unset (no silent x.ai egress). Mock harnesses inject it explicitly. - System-prompt identity fixed: 'released by xAI' → 'an unofficial community CLI for Kimi' (template + regenerated encrypted form). Also repaired pre-existing grok-era test debt found by the sweep: the stale trace_classify default-model pin, the grok-pager UA label test, pty-harness stale-binary reuse and non-hermetic moonshot routing (a PTY test could previously reach the real api.moonshot.cn), and the outdated oauth fixture scope key. Gates: §9 grep 0; fmt clean; workspace check/clippy 0/0 (-D warnings); FULL cargo test --workspace: 234 suites, 21,961 passed, 0 failed; deny advisories ok.
This commit is contained in:
@@ -3,7 +3,7 @@ license = "Apache-2.0"
|
||||
name = "kigi-tools-api"
|
||||
version.workspace = true
|
||||
edition.workspace = true
|
||||
description = "Protobuf API definitions for Grok tools"
|
||||
description = "Protobuf API definitions for Kigi tools"
|
||||
|
||||
[dependencies]
|
||||
tonic-prost = { workspace = true }
|
||||
|
||||
@@ -6,9 +6,9 @@ package kigi.tools.v1;
|
||||
// MAIN SERVICE
|
||||
// ============================================================================
|
||||
|
||||
/// GrokToolsService provides a gRPC interface to the Grok tools runtime.
|
||||
/// KigiToolsService provides a gRPC interface to the Kigi tools runtime.
|
||||
/// It supports tool execution, discovery, configuration, and lifecycle management.
|
||||
service GrokToolsService {
|
||||
service KigiToolsService {
|
||||
// ========== TOOL EXECUTION ==========
|
||||
|
||||
/// Execute a single tool call
|
||||
@@ -213,7 +213,7 @@ message FinalizeToolServerConfigRequest {
|
||||
/// Maps to `ToolConfig` in the tools library.
|
||||
message ToolConfigEntry {
|
||||
/// Fully qualified tool ID: colon-separated `Namespace:tool`
|
||||
/// (e.g., "GrokBuild:bash", "GrokBuild:read_file").
|
||||
/// (e.g., "Kigi:bash", "Kigi:read_file").
|
||||
///
|
||||
/// The whole selection path keys on this format: the default
|
||||
/// client-facing name is the segment after the FIRST colon (see
|
||||
@@ -270,7 +270,7 @@ message FinalizeConfigViolation {
|
||||
/// Structured deprecation/lifecycle warning for a specific tool version
|
||||
/// or bundle. Informational only — does not affect control flow.
|
||||
message VersionWarning {
|
||||
/// Fully-qualified tool ID (e.g. "GrokBuild:run_terminal_cmd").
|
||||
/// Fully-qualified tool ID (e.g. "Kigi:run_terminal_cmd").
|
||||
/// Empty for bundle-level warnings.
|
||||
string fq_tool_id = 1;
|
||||
/// The deprecated version (e.g. "legacy-0.4.10").
|
||||
@@ -637,9 +637,9 @@ message ToolInfo {
|
||||
/// "legacy-0.4.10"). Empty for unmanaged tools.
|
||||
string contract_version = 18;
|
||||
|
||||
/// Tool namespace (e.g. "GrokBuild", "Codex", "OpenCode").
|
||||
/// Tool namespace (e.g. "Kigi", "Codex", "OpenCode").
|
||||
/// Populated by ListTools pre-finalization from the fully-qualified
|
||||
/// registry key (e.g. "GrokBuild:grep" → namespace="GrokBuild").
|
||||
/// registry key (e.g. "Kigi:grep" → namespace="Kigi").
|
||||
string namespace = 19;
|
||||
}
|
||||
|
||||
|
||||
@@ -138,12 +138,12 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn unset_params_is_ok_none() {
|
||||
assert_eq!(parse_params_json(0, "GrokBuild:grep", None), Ok(None));
|
||||
assert_eq!(parse_params_json(0, "Kigi:grep", None), Ok(None));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn valid_object_is_returned() {
|
||||
let parsed = parse_params_json(0, "GrokBuild:grep", Some(r#"{"max_results":50}"#)).unwrap();
|
||||
let parsed = parse_params_json(0, "Kigi:grep", Some(r#"{"max_results":50}"#)).unwrap();
|
||||
assert_eq!(
|
||||
parsed,
|
||||
Some(
|
||||
@@ -157,7 +157,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn empty_string_is_a_parse_error() {
|
||||
let err = parse_params_json(3, "GrokBuild:grep", Some("")).unwrap_err();
|
||||
let err = parse_params_json(3, "Kigi:grep", Some("")).unwrap_err();
|
||||
assert_eq!(err.index, 3);
|
||||
assert_eq!(err.field_path(), "tools[3].params_json");
|
||||
assert!(matches!(
|
||||
@@ -188,10 +188,10 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn name_override_unset_or_valid_is_ok() {
|
||||
assert_eq!(validate_name_override(0, "GrokBuild:grep", None), Ok(()));
|
||||
for name in ["search", "GrokBuild:grep", "a-b_C9"] {
|
||||
assert_eq!(validate_name_override(0, "Kigi:grep", None), Ok(()));
|
||||
for name in ["search", "Kigi:grep", "a-b_C9"] {
|
||||
assert_eq!(
|
||||
validate_name_override(0, "GrokBuild:grep", Some(name)),
|
||||
validate_name_override(0, "Kigi:grep", Some(name)),
|
||||
Ok(()),
|
||||
"name={name:?}"
|
||||
);
|
||||
@@ -201,7 +201,7 @@ mod tests {
|
||||
#[test]
|
||||
fn name_override_outside_charset_is_rejected() {
|
||||
for name in ["has space", "", "a:b:c", "dot.name"] {
|
||||
let err = validate_name_override(2, "GrokBuild:grep", Some(name)).unwrap_err();
|
||||
let err = validate_name_override(2, "Kigi:grep", Some(name)).unwrap_err();
|
||||
assert_eq!(err.index, 2, "name={name:?}");
|
||||
assert_eq!(err.field_path(), "tools[2].name_override");
|
||||
assert!(
|
||||
@@ -228,30 +228,27 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn all_ids_present_returns_none() {
|
||||
let entries = [entry("GrokBuild:grep"), entry("GrokBuild:read_file")];
|
||||
let allowed = allowed(&["GrokBuild:grep", "GrokBuild:read_file", "GrokBuild:bash"]);
|
||||
let entries = [entry("Kigi:grep"), entry("Kigi:read_file")];
|
||||
let allowed = allowed(&["Kigi:grep", "Kigi:read_file", "Kigi:bash"]);
|
||||
assert_eq!(first_unknown_tool_id(&entries, &allowed), None);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn empty_entries_returns_none() {
|
||||
assert_eq!(
|
||||
first_unknown_tool_id(&[], &allowed(&["GrokBuild:grep"])),
|
||||
None
|
||||
);
|
||||
assert_eq!(first_unknown_tool_id(&[], &allowed(&["Kigi:grep"])), None);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn first_unknown_id_is_returned_with_index() {
|
||||
let entries = [
|
||||
entry("GrokBuild:grep"),
|
||||
entry("GrokBuild:nonexistent"),
|
||||
entry("GrokBuild:also_missing"),
|
||||
entry("Kigi:grep"),
|
||||
entry("Kigi:nonexistent"),
|
||||
entry("Kigi:also_missing"),
|
||||
];
|
||||
let allowed = allowed(&["GrokBuild:grep"]);
|
||||
let allowed = allowed(&["Kigi:grep"]);
|
||||
assert_eq!(
|
||||
first_unknown_tool_id(&entries, &allowed),
|
||||
Some((1, "GrokBuild:nonexistent"))
|
||||
Some((1, "Kigi:nonexistent"))
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
//! Shared API definitions for Grok tools: protobuf types, config validation,
|
||||
//! Shared API definitions for Kigi tools: protobuf types, config validation,
|
||||
//! and canonical slash-command wording.
|
||||
//!
|
||||
//! Used by both the tools library and the gRPC server, and by host services
|
||||
@@ -96,7 +96,7 @@ pub use pb::{
|
||||
|
||||
/// Default client-facing tool name derived from a namespaced tool id.
|
||||
///
|
||||
/// Tool ids are colon-separated `Namespace:tool` (e.g. `GrokBuild:grep`); the
|
||||
/// Tool ids are colon-separated `Namespace:tool` (e.g. `Kigi:grep`); the
|
||||
/// default name is the segment after the FIRST colon, so an id with embedded
|
||||
/// colons (`ns:a:b`) resolves to `a`. Ids without a colon are returned as-is.
|
||||
///
|
||||
@@ -131,7 +131,7 @@ mod default_client_name_tests {
|
||||
|
||||
#[test]
|
||||
fn pins_first_colon_derivation() {
|
||||
assert_eq!(default_client_name("GrokBuild:grep"), "grep");
|
||||
assert_eq!(default_client_name("Kigi:grep"), "grep");
|
||||
assert_eq!(default_client_name("ns:a:b"), "a");
|
||||
assert_eq!(default_client_name("bare"), "bare");
|
||||
assert_eq!(default_client_name(""), "");
|
||||
|
||||
@@ -9,7 +9,7 @@ use kigi_tools_api::ToolConfigEntry;
|
||||
|
||||
fn full_entry() -> ToolConfigEntry {
|
||||
ToolConfigEntry {
|
||||
id: "GrokBuild:grep".to_owned(),
|
||||
id: "Kigi:grep".to_owned(),
|
||||
params_json: Some(r#"{"max_results":50}"#.to_owned()),
|
||||
name_override: Some("search".to_owned()),
|
||||
params_name_overrides: std::collections::HashMap::from([(
|
||||
@@ -27,7 +27,7 @@ fn tool_config_entry_serializes_to_pinned_json_shape() {
|
||||
assert_eq!(
|
||||
value,
|
||||
serde_json::json!({
|
||||
"id": "GrokBuild:grep",
|
||||
"id": "Kigi:grep",
|
||||
"params_json": "{\"max_results\":50}",
|
||||
"name_override": "search",
|
||||
"params_name_overrides": {"pattern": "query"},
|
||||
@@ -48,10 +48,9 @@ fn tool_config_entry_round_trips() {
|
||||
#[test]
|
||||
fn minimal_entry_deserializes_from_id_only() {
|
||||
// Consumers must accept sparse payloads: optional fields absent, map empty.
|
||||
let back: ToolConfigEntry =
|
||||
serde_json::from_value(serde_json::json!({"id": "GrokBuild:read_file"}))
|
||||
.expect("deserialize minimal");
|
||||
assert_eq!(back.id, "GrokBuild:read_file");
|
||||
let back: ToolConfigEntry = serde_json::from_value(serde_json::json!({"id": "Kigi:read_file"}))
|
||||
.expect("deserialize minimal");
|
||||
assert_eq!(back.id, "Kigi:read_file");
|
||||
assert_eq!(back.params_json, None);
|
||||
assert_eq!(back.name_override, None);
|
||||
assert!(back.params_name_overrides.is_empty());
|
||||
@@ -73,7 +72,7 @@ fn explicit_null_optional_fields_deserialize_as_none() {
|
||||
// `#[serde(default)]` covers *absent* keys; explicit `null` is handled by
|
||||
// the `Option` fields themselves. Pin that both shapes are accepted.
|
||||
let back: ToolConfigEntry = serde_json::from_value(serde_json::json!({
|
||||
"id": "GrokBuild:read_file",
|
||||
"id": "Kigi:read_file",
|
||||
"params_json": null,
|
||||
"name_override": null,
|
||||
"behavior_version": null,
|
||||
@@ -92,7 +91,7 @@ fn explicit_null_map_is_rejected() {
|
||||
// map. Producers must omit the key or emit `{}`. Pin the rejection so a
|
||||
// codegen change that silently starts accepting `null` is caught.
|
||||
let result: Result<ToolConfigEntry, _> = serde_json::from_value(serde_json::json!({
|
||||
"id": "GrokBuild:read_file",
|
||||
"id": "Kigi:read_file",
|
||||
"params_name_overrides": null,
|
||||
}));
|
||||
assert!(
|
||||
|
||||
Reference in New Issue
Block a user