docs(comments): rewrite comments across all crates to the guidelines

Sweep every first-party crate source (1956 .rs files) to the project comment
guidelines: delete redundant restatements, decorative banners, change
narration, and end-of-line comments; keep and tighten the crucial ones
(invariants, bug rationale, SAFETY blocks, ported-source attribution).

No functional code changed. Every edit is proven comment-only against the
prior tree by a comment-stripping lexer (string/char/raw-string aware) plus a
separate doctest-fence check. Where removing a comment made rustfmt or clippy
want to re-lay-out adjacent code, the minimal triggering comment is restored so
code tokens stay byte-identical.

Gates green: cargo fmt --all --check (0 diffs), cargo check and cargo clippy
--workspace --all-targets (0 warnings).

Adds scripts/check_codegen_comment_guidelines.py — the enforcement gate for
these guidelines (flags banners, end-of-line comments, change narration, and
commented-out code).
This commit is contained in:
ZacharyZhang-NY committed 2026-07-23 16:55:39 -04:00
1 parent ff0fb56c67
commit a02b555e66
1458 files changed
+10729 -21750

No files matched your search

@@ -35,7 +35,6 @@ struct CollectorState {
}
impl DoomLoopSignalCollector {
/// A fresh, armed collector judging confidence with `policy`.
pub(crate) fn new(policy: DoomLoopRecoveryPolicy) -> Self {
let collector = Self::default();
if let Ok(mut state) = collector.inner.lock() {
@@ -90,7 +89,6 @@ impl DoomLoopSignalCollector {
swallow || named
}
/// Drain the recorded signals; empty when nothing was reported.
pub(crate) fn take(&self) -> Vec<DoomLoopSignal> {
match self.inner.lock() {
Ok(mut state) => std::mem::take(&mut state.signals),
@@ -111,7 +109,6 @@ impl DoomLoopSignalCollector {
}
}
/// Debug-log the first malformed payload per attempt (never per event).
fn log_malformed_once(&self) {
let Ok(mut state) = self.inner.lock() else {
return;
@@ -139,8 +136,6 @@ mod tests {
assert_eq!(signals[0].kind, DoomLoopSignalKind::TailRepetition(4));
}
/// Servers that omit the SSE `event:` name are still handled by the
/// payload `type` check.
#[test]
fn absorb_swallows_check_event_without_sse_name() {
let collector = DoomLoopSignalCollector::default();
@@ -168,7 +163,6 @@ mod tests {
let delta = r#"{"type":"response.output_text.delta","delta":"hi"}"#;
assert!(!collector.absorb("response.output_text.delta", delta));
assert!(collector.take().is_empty());
// Terminal response field is recorded but the event is forwarded.
let terminal = r#"{"type":"response.completed","response":{"id":"r1","doom_loop_check":{"triggers":["low_logprob@response"]}}}"#;
assert!(!collector.absorb("response.completed", terminal));
assert_eq!(collector.take().len(), 1);
@@ -203,8 +197,6 @@ mod tests {
assert!(collector.take().is_empty());
}
/// `abort_triggers` fires only on confident signals, does not drain, and
/// goes quiet once disarmed (the spent-budget attempt must complete).
#[test]
fn abort_triggers_requires_confidence_and_honors_disarm() {
let confident = r#"{"type":"response.doom_loop_check","doom_loop_check":{"triggers":["tail_repetition:8@thinking"]}}"#;