docs(comments): rewrite comments across all crates to the guidelines
Sweep every first-party crate source (1956 .rs files) to the project comment guidelines: delete redundant restatements, decorative banners, change narration, and end-of-line comments; keep and tighten the crucial ones (invariants, bug rationale, SAFETY blocks, ported-source attribution). No functional code changed. Every edit is proven comment-only against the prior tree by a comment-stripping lexer (string/char/raw-string aware) plus a separate doctest-fence check. Where removing a comment made rustfmt or clippy want to re-lay-out adjacent code, the minimal triggering comment is restored so code tokens stay byte-identical. Gates green: cargo fmt --all --check (0 diffs), cargo check and cargo clippy --workspace --all-targets (0 warnings). Adds scripts/check_codegen_comment_guidelines.py — the enforcement gate for these guidelines (flags banners, end-of-line comments, change narration, and commented-out code).
This commit is contained in:
@@ -48,7 +48,6 @@ pub fn parse_params_str<T: DeserializeOwned>(raw: &str) -> Result<T, acp::Error>
|
||||
serde_json::from_str(raw)
|
||||
.map_err(|e| acp::Error::invalid_params().data(format!("invalid params: {}", e)))
|
||||
}
|
||||
/// Extract the session ID from an extension request's params.
|
||||
pub fn parse_session_id(args: &acp::ExtRequest) -> Option<acp::SessionId> {
|
||||
let v: serde_json::Value = serde_json::from_str(args.params.get()).ok()?;
|
||||
let sid = v.get("sessionId")?.as_str()?;
|
||||
@@ -65,7 +64,6 @@ pub fn to_raw_response<T: Serialize>(v: &T) -> ExtResult {
|
||||
.map(|raw| acp::ExtResponse::new(Arc::from(raw)))
|
||||
.map_err(|e| acp::Error::internal_error().data(e.to_string()))
|
||||
}
|
||||
/// Convert a result with optional warning to an ExtResponse.
|
||||
pub fn to_ext_response_partial<T: Serialize>(
|
||||
result: anyhow::Result<T>,
|
||||
warning: Option<String>,
|
||||
@@ -79,6 +77,5 @@ pub fn to_ext_response_partial<T: Serialize>(
|
||||
.to_ext_response()
|
||||
.map_err(|e| acp::Error::internal_error().data(e.to_string()))
|
||||
}
|
||||
/// Empty response for operations that return no data.
|
||||
#[derive(Debug, Serialize)]
|
||||
pub struct Empty {}
|
||||
|
||||
Reference in New Issue
Block a user