ZacharyZhang-NY/Kigi-CLI
1
0
Fork 0
Code Issues Pull Requests Actions 13 Packages Projects Releases Wiki Activity

docs(comments): rewrite comments across all crates to the guidelines

Browse Source 
Sweep every first-party crate source (1956 .rs files) to the project comment
guidelines: delete redundant restatements, decorative banners, change
narration, and end-of-line comments; keep and tighten the crucial ones
(invariants, bug rationale, SAFETY blocks, ported-source attribution).

No functional code changed. Every edit is proven comment-only against the
prior tree by a comment-stripping lexer (string/char/raw-string aware) plus a
separate doctest-fence check. Where removing a comment made rustfmt or clippy
want to re-lay-out adjacent code, the minimal triggering comment is restored so
code tokens stay byte-identical.

Gates green: cargo fmt --all --check (0 diffs), cargo check and cargo clippy
--workspace --all-targets (0 warnings).

Adds scripts/check_codegen_comment_guidelines.py — the enforcement gate for
these guidelines (flags banners, end-of-line comments, change narration, and
commented-out code).
This commit is contained in:
ZacharyZhang-NY
2026-07-23 16:55:39 -04:00
parent ff0fb56c67
commit a02b555e66
1458 changed files with 10729 additions and 21750 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/codegen/kigi-shell/tests/test_refusal_stop_reason.rs
+9 -10
View File
@@ -2,11 +2,11 @@
//! `stop_reason: "refusal"` must complete the turn cleanly with EXACTLY ONE
//! inference request.
//!
//! Previously the unknown `stop_reason` failed the terminal `message_delta`
//! parse (discarding the fully-streamed response) and the resulting
//! serialization error was misclassified as a retryable stream error,
//! producing a ~10-minute retry storm per turn. Covered here end-to-end
//! through both the plain stdio agent and a leader-hosted session.
//! An unknown `stop_reason` fails the terminal `message_delta` parse
//! (discarding the fully-streamed response); the resulting serialization
//! error is misclassified as a retryable stream error, producing a
//! ~10-minute retry storm per turn. Covered here end-to-end through both
//! the plain stdio agent and a leader-hosted session.
//!
//! Tests are `#[ignore]`d by default — they require a pre-built binary
//! (auto-built locally when missing):
@@ -65,8 +65,9 @@ fn turn_messages_request_count(server: &MockInferenceServer) -> usize {
/// THE regression test: a refusal-terminated `/v1/messages` turn must return
/// a successful prompt response from exactly one inference request.
// requires pre-built binary; run with --ignored
#[tokio::test]
#[ignore] // requires pre-built binary; run with --ignored
#[ignore]
async fn test_refusal_turn_completes_with_single_messages_request() {
with_local_set(|| async {
let server = refusal_messages_server().await;
@@ -111,11 +112,8 @@ async fn test_refusal_turn_completes_with_single_messages_request() {
.await;
}
// ============================================================================
// Leader mode: the same refusal scenario through a leader-hosted session
// (client → stdio bridge → leader unix socket → leader-hosted agent).
// ============================================================================
#[cfg(unix)]
mod leader {
use std::time::Duration;
@@ -130,8 +128,9 @@ mod leader {
/// Leader-mode variant of the regression: the refusal-terminated turn
/// must complete cleanly (single request, prompt response delivered)
/// when the session is hosted by the leader IPC server.
// requires pre-built binary; run with --ignored
#[tokio::test]
#[ignore] // requires pre-built binary; run with --ignored
#[ignore]
async fn test_leader_refusal_turn_completes_with_single_messages_request() {
with_local_set(|| async {
let server = refusal_messages_server().await;