feat(login): /login opens the provider picker with green connected badges

/login previously fired the resolved method's flow immediately — there was
no way to see providers or their status. It now lands on the provider
picker; already-connected providers show a green 'connected' badge in the
key column.

Shell: initialize() probes stored credentials once (primary session flag,
auth.json oauth/<provider> scopes, resolved platform keys env>auth.json>
config) and stamps _meta.connected on each advertised method
(connected_method_ids + stamp_connected_meta, pure and unit-tested).
Display state only — never an authorization input.

TUI:
- PendingMenuItem::connected() reads the badge from method meta; the
  picker renders it green (accent_success), replacing the shortcut hint.
- New Action::OpenLoginPicker: /login shows the picker; mid-session it
  stashes the view like dispatch_login, and starts no flow by itself.
- Mid-session picker: last row reads 'Cancel' and dispatches CancelLogin
  (clicking it must not exit the app); Esc also returns to the session.
- After a successful login, the just-authenticated method is stamped
  connected in the TUI's advertised-methods copy (auth_in_flight_method →
  AuthComplete), so a later /login shows the badge without re-initialize.

Verified: kigi-shell 5256 + kigi-tui 6870 tests green, clippy clean.
This commit is contained in:
2026-07-22 16:14:42 -04:00
parent 1e57cd9225
commit fc7c2a1b9b
11 changed files with 384 additions and 15 deletions
@@ -437,6 +437,68 @@ pub fn platform_auth_method(platform: kigi_models::PlatformId) -> acp::AuthMetho
)
}
/// `_meta` key advertised on auth methods that already hold a stored
/// credential: the client's login picker renders these rows with a green
/// "connected" badge. Display state only — NEVER an authorization input.
pub const CONNECTED_META_KEY: &str = "connected";
/// Which advertised method ids already hold a stored credential.
///
/// Pure given its inputs so it unit-tests without disk or env:
/// - `has_cached_token` / `has_external_api_key` — the same flags
/// `build_auth_methods` consumed,
/// - `has_scope` — whether auth.json holds an entry at a scope key
/// (subscription-OAuth sessions live at `oauth/<provider>`),
/// - `has_platform_key` — whether an API-key platform resolves a key
/// (env > auth.json > config; see `PlatformApiKeys`).
pub fn connected_method_ids(
has_cached_token: bool,
has_external_api_key: bool,
has_scope: impl Fn(&str) -> bool,
has_platform_key: impl Fn(kigi_models::PlatformId) -> bool,
) -> std::collections::HashSet<&'static str> {
let mut connected = std::collections::HashSet::new();
if has_cached_token {
connected.insert(KIMI_CODE_METHOD_ID);
connected.insert(CACHED_TOKEN_AUTH_METHOD_ID);
}
if has_external_api_key {
connected.insert(XAI_API_KEY_METHOD_ID);
}
for platform in kigi_models::PlatformId::ALL {
match platform.oauth() {
Some(oauth) if has_scope(oauth.scope_key) => {
connected.insert(platform.as_str());
}
None if !platform.uses_oauth() && has_platform_key(platform) => {
connected.insert(platform.as_str());
}
_ => {}
}
}
connected
}
/// Stamp [`CONNECTED_META_KEY`] onto every advertised method in `connected`.
pub fn stamp_connected_meta(
methods: &mut [acp::AuthMethod],
connected: &std::collections::HashSet<&'static str>,
) {
for method in methods.iter_mut() {
if !connected.contains(method.id().0.as_ref()) {
continue;
}
if let acp::AuthMethod::Agent(agent) = method {
let mut meta = agent.meta.take().unwrap_or_default();
meta.insert(
CONNECTED_META_KEY.to_string(),
serde_json::Value::Bool(true),
);
agent.meta = Some(meta);
}
}
}
/// Actionable error for a platform `authenticate` with no key configured.
pub fn missing_platform_key_error(platform: kigi_models::PlatformId) -> String {
match platform.api_key_env_names().first() {
@@ -1064,6 +1126,53 @@ mod tests {
assert_eq!(read_xai_api_key_env().unwrap(), "house-key");
}
/// Connected-badge probing: the primary session marks kimi-code (and
/// cached_token), a stored `oauth/<provider>` scope marks that provider,
/// a resolvable platform key marks its API-key row — and nothing else.
#[test]
fn connected_method_ids_maps_credentials_to_method_ids() {
let connected = connected_method_ids(
true,
false,
|scope| scope == "oauth/claude-pro-max",
|p| p == kigi_models::PlatformId::DeepSeek,
);
assert!(connected.contains(KIMI_CODE_METHOD_ID));
assert!(connected.contains(CACHED_TOKEN_AUTH_METHOD_ID));
assert!(connected.contains("claude-pro-max"));
assert!(connected.contains("deepseek"));
assert!(!connected.contains("xai-grok"), "no stored grok session");
assert!(!connected.contains("openai"), "no openai key");
assert!(!connected.contains(XAI_API_KEY_METHOD_ID), "no house key");
// Nothing stored → nothing connected.
let none = connected_method_ids(false, false, |_| false, |_| false);
assert!(none.is_empty(), "{none:?}");
}
/// Stamping writes `_meta.connected: true` on exactly the connected
/// methods and leaves every other method's meta untouched.
#[test]
fn stamp_connected_meta_marks_only_connected_methods() {
let mut methods = build_auth_methods(default_inputs()).methods;
let connected = std::collections::HashSet::from(["claude-pro-max"]);
stamp_connected_meta(&mut methods, &connected);
for method in &methods {
let marked = method
.meta()
.as_ref()
.and_then(|m| m.get(CONNECTED_META_KEY))
.and_then(|v| v.as_bool())
.unwrap_or(false);
assert_eq!(
marked,
method.id().0.as_ref() == "claude-pro-max",
"only claude-pro-max may carry the badge, got it on {}",
method.id().0
);
}
}
/// Moonshot authenticate with no configured key: actionable error naming
/// the platform, the login screen, and the platform-scoped env var. No
/// HTTP is attempted (`key: None` short-circuits).