Sweep every first-party crate source (1956 .rs files) to the project comment guidelines: delete redundant restatements, decorative banners, change narration, and end-of-line comments; keep and tighten the crucial ones (invariants, bug rationale, SAFETY blocks, ported-source attribution). No functional code changed. Every edit is proven comment-only against the prior tree by a comment-stripping lexer (string/char/raw-string aware) plus a separate doctest-fence check. Where removing a comment made rustfmt or clippy want to re-lay-out adjacent code, the minimal triggering comment is restored so code tokens stay byte-identical. Gates green: cargo fmt --all --check (0 diffs), cargo check and cargo clippy --workspace --all-targets (0 warnings). Adds scripts/check_codegen_comment_guidelines.py — the enforcement gate for these guidelines (flags banners, end-of-line comments, change narration, and commented-out code).
248 lines
9.0 KiB
Rust
248 lines
9.0 KiB
Rust
//! Forks a saved session to a new working directory with a new session ID.
|
|
//! This creates new session files but does not start the session.
|
|
|
|
const FORK_LOG: &str = "kigi_fork";
|
|
use crate::session::info::Info;
|
|
use crate::session::storage::{CopySessionOptions, JsonlStorageAdapter};
|
|
use crate::util::kigi_home::kigi_home;
|
|
use agent_client_protocol as acp;
|
|
use std::io;
|
|
|
|
#[derive(Debug, Clone, Default, serde::Serialize, serde::Deserialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
pub struct ForkSessionRequest {
|
|
pub source_session_id: String,
|
|
pub source_cwd: String,
|
|
pub new_cwd: String,
|
|
/// Client-provided session ID for the forked session.
|
|
/// If None, a new ID will be auto-generated.
|
|
#[serde(default)]
|
|
pub new_session_id: Option<String>,
|
|
/// Optional model ID override for the forked session.
|
|
/// If None, the source session's model will be used.
|
|
#[serde(default)]
|
|
pub new_model_id: Option<String>,
|
|
#[serde(default)]
|
|
pub target_prompt_index: Option<usize>,
|
|
/// Override `session_kind` in the forked summary. Defaults to `"fork"`.
|
|
/// Worktree forks set this to `"worktree"`.
|
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
|
pub session_kind: Option<String>,
|
|
/// The original workspace directory this worktree session was spawned from.
|
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
|
pub source_workspace_dir: Option<String>,
|
|
}
|
|
|
|
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
pub struct ForkSessionResponse {
|
|
pub new_session_id: String,
|
|
pub chat_messages_copied: usize,
|
|
pub updates_copied: usize,
|
|
pub plan_state_copied: bool,
|
|
pub new_cwd: String,
|
|
pub parent_session_id: String,
|
|
#[serde(skip_serializing_if = "Option::is_none")]
|
|
pub new_model_id: Option<String>,
|
|
}
|
|
|
|
/// Generate a forked session ID: a plain UUIDv7 with no prefix or source
|
|
/// embedding, so IDs stay a constant 36 chars regardless of how many fork
|
|
/// rounds occur.
|
|
fn generate_fork_session_id(_source_id: &str) -> String {
|
|
uuid::Uuid::now_v7().to_string()
|
|
}
|
|
|
|
pub async fn fork_session(request: ForkSessionRequest) -> io::Result<ForkSessionResponse> {
|
|
let t0 = std::time::Instant::now();
|
|
|
|
let root_dir = kigi_home();
|
|
let storage = JsonlStorageAdapter::with_root(root_dir.clone());
|
|
|
|
let source_info = Info {
|
|
id: acp::SessionId::new(request.source_session_id.clone()),
|
|
cwd: request.source_cwd.clone(),
|
|
};
|
|
|
|
let new_session_id = request
|
|
.new_session_id
|
|
.clone()
|
|
.unwrap_or_else(|| generate_fork_session_id(&request.source_session_id));
|
|
|
|
let target_info = Info {
|
|
id: acp::SessionId::new(new_session_id.clone()),
|
|
cwd: request.new_cwd.clone(),
|
|
};
|
|
|
|
// Runs on the blocking thread pool so concurrent fork copies can execute
|
|
// truly in parallel (on a LocalSet, async copy_session_data serializes
|
|
// because the sync disk I/O blocks the single-threaded runtime).
|
|
let options = CopySessionOptions {
|
|
parent_session_id: Some(request.source_session_id.clone()),
|
|
new_model_id: request.new_model_id.clone(),
|
|
target_prompt_index: request.target_prompt_index,
|
|
session_kind: request.session_kind.clone(),
|
|
source_workspace_dir: request.source_workspace_dir.clone(),
|
|
// Carry the parent's compaction segment archive into the fork so the
|
|
// child retains pre-compaction history (the live summary is already
|
|
// copied via chat_history.jsonl).
|
|
copy_compaction_segments: true,
|
|
..Default::default()
|
|
};
|
|
|
|
let result = tokio::task::spawn_blocking(move || {
|
|
storage.copy_session_data_sync(&source_info, &target_info, options)
|
|
})
|
|
.await
|
|
.map_err(|e| io::Error::other(format!("spawn_blocking panicked: {e}")))??;
|
|
|
|
let copy_ms = t0.elapsed().as_millis() as u64;
|
|
|
|
let total_ms = t0.elapsed().as_millis() as u64;
|
|
tracing::info!(
|
|
target: FORK_LOG,
|
|
session_id = %new_session_id,
|
|
source_session = %request.source_session_id,
|
|
copy_ms,
|
|
total_ms,
|
|
chat_copied = result.chat_messages_copied,
|
|
updates_copied = result.updates_copied,
|
|
"FORK_COPY: session data copied"
|
|
);
|
|
|
|
Ok(ForkSessionResponse {
|
|
new_session_id,
|
|
chat_messages_copied: result.chat_messages_copied,
|
|
updates_copied: result.updates_copied,
|
|
plan_state_copied: result.plan_state_copied,
|
|
new_cwd: request.new_cwd,
|
|
parent_session_id: request.source_session_id,
|
|
new_model_id: request.new_model_id,
|
|
})
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_generate_fork_session_id_format() {
|
|
let fork_id = generate_fork_session_id("abc123");
|
|
|
|
// Should be a valid UUIDv7 (36 chars with dashes)
|
|
assert_eq!(
|
|
fork_id.len(),
|
|
36,
|
|
"Fork ID should be a standard UUID length"
|
|
);
|
|
assert!(
|
|
uuid::Uuid::parse_str(&fork_id).is_ok(),
|
|
"Fork ID should be a valid UUID: {}",
|
|
fork_id
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_generate_fork_session_id_uniqueness() {
|
|
// Generate multiple IDs rapidly and ensure they're all unique
|
|
let mut ids = std::collections::HashSet::new();
|
|
for _ in 0..100 {
|
|
let fork_id = generate_fork_session_id("any-source");
|
|
assert_eq!(fork_id.len(), 36);
|
|
ids.insert(fork_id);
|
|
}
|
|
|
|
// All 100 should be unique
|
|
assert_eq!(ids.len(), 100, "All generated IDs should be unique");
|
|
}
|
|
|
|
#[test]
|
|
fn test_generate_fork_session_id_constant_length() {
|
|
// Forking from already-forked sessions should produce same-length IDs
|
|
let id1 = generate_fork_session_id("019c43b5-c4ae-7190-b058-693e24669ba9");
|
|
let id2 = generate_fork_session_id(&id1);
|
|
let id3 = generate_fork_session_id(&id2);
|
|
|
|
assert_eq!(id1.len(), 36);
|
|
assert_eq!(id2.len(), 36);
|
|
assert_eq!(id3.len(), 36);
|
|
}
|
|
|
|
#[test]
|
|
fn test_fork_session_request_serialization() {
|
|
let request = ForkSessionRequest {
|
|
source_session_id: "abc123".to_string(),
|
|
source_cwd: "/old/project".to_string(),
|
|
new_cwd: "/new/project".to_string(),
|
|
new_session_id: Some("custom-session-id".to_string()),
|
|
new_model_id: Some("kigi-3".to_string()),
|
|
target_prompt_index: None,
|
|
..Default::default()
|
|
};
|
|
|
|
let json = serde_json::to_string(&request).unwrap();
|
|
let deserialized: ForkSessionRequest = serde_json::from_str(&json).unwrap();
|
|
|
|
assert_eq!(deserialized.source_session_id, "abc123");
|
|
assert_eq!(deserialized.source_cwd, "/old/project");
|
|
assert_eq!(deserialized.new_cwd, "/new/project");
|
|
assert_eq!(
|
|
deserialized.new_session_id,
|
|
Some("custom-session-id".to_string())
|
|
);
|
|
assert_eq!(deserialized.new_model_id, Some("kigi-3".to_string()));
|
|
}
|
|
|
|
#[test]
|
|
fn test_fork_session_request_without_optional_fields() {
|
|
// Test that optional fields default to None when not provided
|
|
let json = r#"{"sourceSessionId":"abc123","sourceCwd":"/old","newCwd":"/new"}"#;
|
|
let deserialized: ForkSessionRequest = serde_json::from_str(json).unwrap();
|
|
|
|
assert_eq!(deserialized.source_session_id, "abc123");
|
|
assert_eq!(deserialized.new_session_id, None);
|
|
assert_eq!(deserialized.new_model_id, None);
|
|
}
|
|
|
|
#[test]
|
|
fn test_fork_session_response_serialization() {
|
|
let response = ForkSessionResponse {
|
|
new_session_id: "fork-abc123-12345678".to_string(),
|
|
chat_messages_copied: 42,
|
|
updates_copied: 156,
|
|
plan_state_copied: true,
|
|
new_cwd: "/new/project".to_string(),
|
|
parent_session_id: "abc123".to_string(),
|
|
new_model_id: Some("kigi-3".to_string()),
|
|
};
|
|
|
|
let json = serde_json::to_string(&response).unwrap();
|
|
let deserialized: ForkSessionResponse = serde_json::from_str(&json).unwrap();
|
|
|
|
assert_eq!(deserialized.new_session_id, "fork-abc123-12345678");
|
|
assert_eq!(deserialized.chat_messages_copied, 42);
|
|
assert_eq!(deserialized.updates_copied, 156);
|
|
assert!(deserialized.plan_state_copied);
|
|
assert_eq!(deserialized.new_cwd, "/new/project");
|
|
assert_eq!(deserialized.parent_session_id, "abc123");
|
|
assert_eq!(deserialized.new_model_id, Some("kigi-3".to_string()));
|
|
}
|
|
|
|
#[test]
|
|
fn test_fork_session_response_without_model_override() {
|
|
let response = ForkSessionResponse {
|
|
new_session_id: "fork-abc123-12345678".to_string(),
|
|
chat_messages_copied: 42,
|
|
updates_copied: 156,
|
|
plan_state_copied: true,
|
|
new_cwd: "/new/project".to_string(),
|
|
parent_session_id: "abc123".to_string(),
|
|
new_model_id: None,
|
|
};
|
|
|
|
let json = serde_json::to_string(&response).unwrap();
|
|
// new_model_id should not be present in JSON when None
|
|
assert!(!json.contains("new_model_id"));
|
|
}
|
|
}
|