kigi allowed loopback unconditionally and missed several non-public ranges, and the SSRF check ran only on the initial URL. Policy (ssrf.rs): - loopback is blocked unless `[toolset.web_fetch] allow_local` (or KIGI_WEB_FETCH_ALLOW_LOCAL) is on, AND the URL names it explicitly, so a public name resolving to loopback stays blocked (DNS rebinding) - add 0.0.0.0/8, 100.64/10, 192.0.0.0/24, TEST-NET-1/2/3, 198.18/15, 240/4, IPv6 site-local and documentation prefixes - inherit the IPv4 verdict through mapped, compatible, NAT64 and 6to4 wrappers; network-specific NAT64 prefixes remain uncovered (see doc) Plumbing (client.rs), where the exploitable half lived: - re-check every redirect hop, not just the first - compare hosts exactly; a `www` sibling has its own A records, so it is a cross-host redirect rather than an auto-followed hop - run the check before the fetch service, so a blocked URL is never posted to an endpoint that egresses elsewhere - exempt explicit local hosts from the https upgrade and from the single-label filter, and re-upgrade each followed hop Wiring: allow_local reaches WebFetchParams from both construction paths; documented in the config guide and the README env table.
203 lines
5.8 KiB
Rust
203 lines
5.8 KiB
Rust
//! Runtime-configurable parameters for the `web_fetch` tool.
|
|
|
|
use std::time::Duration;
|
|
|
|
use serde::{Deserialize, Serialize};
|
|
|
|
use crate::register_resource;
|
|
|
|
// Safety-boundary constants. Not configurable.
|
|
pub const MAX_URL_LENGTH: usize = 2_000;
|
|
pub const MAX_REDIRECTS: usize = 10;
|
|
pub const USER_AGENT_STRING: &str =
|
|
"Mozilla/5.0 (compatible; kigi-agent/1.0; +https://github.com/ZacharyZhang-NY/Kigi-CLI)";
|
|
|
|
/// Runtime-configurable parameters for the `web_fetch` tool.
|
|
///
|
|
/// Injected via `Params<WebFetchParams>` in `SharedResources`.
|
|
/// All fields are optional — `None` means "use built-in default."
|
|
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
|
|
#[serde(deny_unknown_fields)]
|
|
pub struct WebFetchParams {
|
|
/// Cache time-to-live in seconds. Default: 900 (15 minutes).
|
|
pub cache_ttl_secs: Option<u64>,
|
|
/// Maximum number of cached pages. Default: 128.
|
|
pub max_cache_entries: Option<usize>,
|
|
/// HTTP request timeout in seconds. Default: 60.
|
|
pub timeout_secs: Option<u64>,
|
|
/// Maximum response body size in bytes. Default: 10 MB.
|
|
pub max_content_length: Option<usize>,
|
|
/// Maximum inline markdown output length in bytes. Default: 100,000.
|
|
pub max_markdown_length: Option<usize>,
|
|
/// Model context window size in tokens. Used to enforce 3% cap on web content.
|
|
pub context_window_tokens: Option<u64>,
|
|
/// Domains the tool is allowed to fetch. All other
|
|
/// domains are rejected before any network I/O.
|
|
/// Defaults to `DEFAULT_ALLOWED_DOMAINS` if no
|
|
/// list given.
|
|
#[serde(default)]
|
|
pub allowed_domains: Option<Vec<String>>,
|
|
/// Optional egress proxy endpoint. When set, all HTTP requests are
|
|
/// routed through this URL.
|
|
#[serde(default)]
|
|
pub proxy_endpoint: Option<String>,
|
|
/// Kimi fetch service endpoint (`POST {coding_base}/fetch`, PRD F5).
|
|
/// Set by the shell for Kimi Code OAuth sessions; when present, the
|
|
/// tool tries the service first and falls back to the local pipeline
|
|
/// on any failure (kimi-cli `tools/web/fetch.py FetchURL.__call__`).
|
|
#[serde(default)]
|
|
pub service_url: Option<String>,
|
|
/// Opt-in for loopback targets; off means no local access.
|
|
#[serde(default)]
|
|
pub allow_local: Option<bool>,
|
|
}
|
|
|
|
register_resource!("kigi", "WebFetch", WebFetchParams);
|
|
|
|
// Keep defaults here so call-sites don't have to manage unwrapping.
|
|
impl WebFetchParams {
|
|
/// From config or `KIGI_WEB_FETCH_ALLOW_LOCAL`, never tool input.
|
|
pub fn allow_local(&self) -> bool {
|
|
self.allow_local.unwrap_or(false)
|
|
}
|
|
|
|
pub fn cache_ttl_secs(&self) -> Duration {
|
|
Duration::from_secs(self.cache_ttl_secs.unwrap_or(15 * 60))
|
|
}
|
|
|
|
pub fn max_cache_entries(&self) -> usize {
|
|
self.max_cache_entries.unwrap_or(128)
|
|
}
|
|
|
|
pub fn timeout_secs(&self) -> Duration {
|
|
Duration::from_secs(self.timeout_secs.unwrap_or(60))
|
|
}
|
|
|
|
pub fn max_content_length(&self) -> usize {
|
|
self.max_content_length.unwrap_or(10 * 1024 * 1024)
|
|
}
|
|
|
|
pub fn max_markdown_length(&self) -> usize {
|
|
self.max_markdown_length.unwrap_or(100_000)
|
|
}
|
|
|
|
pub fn context_window_tokens(&self) -> u64 {
|
|
self.context_window_tokens.unwrap_or(128_000)
|
|
}
|
|
|
|
pub fn allowed_domains(&self) -> Vec<String> {
|
|
match &self.allowed_domains {
|
|
Some(v) => v.clone(),
|
|
None => DEFAULT_ALLOWED_DOMAINS
|
|
.iter()
|
|
.map(|s| (*s).to_owned())
|
|
.collect(),
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Default allowlist for web_fetch tool.
|
|
/// Note: GET-only preapproved domains. Path-scoped entries (e.g. vercel.com/docs) are included as-is.
|
|
pub static DEFAULT_ALLOWED_DOMAINS: &[&str] = &[
|
|
// Kimi / Moonshot
|
|
"kimi.com",
|
|
"platform.moonshot.ai",
|
|
"platform.moonshot.cn",
|
|
// Programming languages
|
|
"docs.python.org",
|
|
"en.cppreference.com",
|
|
"docs.oracle.com",
|
|
"learn.microsoft.com",
|
|
"developer.mozilla.org",
|
|
"go.dev",
|
|
"pkg.go.dev",
|
|
"www.php.net",
|
|
"docs.swift.org",
|
|
"kotlinlang.org",
|
|
"ruby-doc.org",
|
|
"doc.rust-lang.org",
|
|
"docs.rs",
|
|
"www.typescriptlang.org",
|
|
// Web and JS frameworks
|
|
"react.dev",
|
|
"angular.io",
|
|
"vuejs.org",
|
|
"nextjs.org",
|
|
"expressjs.com",
|
|
"nodejs.org",
|
|
"bun.sh",
|
|
"jquery.com",
|
|
"getbootstrap.com",
|
|
"tailwindcss.com",
|
|
"d3js.org",
|
|
"threejs.org",
|
|
"redux.js.org",
|
|
"webpack.js.org",
|
|
"jestjs.io",
|
|
"reactrouter.com",
|
|
// Python frameworks
|
|
"docs.djangoproject.com",
|
|
"flask.palletsprojects.com",
|
|
"fastapi.tiangolo.com",
|
|
"pandas.pydata.org",
|
|
"numpy.org",
|
|
"www.tensorflow.org",
|
|
"pytorch.org",
|
|
"scikit-learn.org",
|
|
"matplotlib.org",
|
|
"requests.readthedocs.io",
|
|
"jupyter.org",
|
|
// PHP frameworks
|
|
"laravel.com",
|
|
"symfony.com",
|
|
"wordpress.org",
|
|
// Java frameworks
|
|
"docs.spring.io",
|
|
"hibernate.org",
|
|
"tomcat.apache.org",
|
|
"gradle.org",
|
|
"maven.apache.org",
|
|
// .NET
|
|
"asp.net",
|
|
"dotnet.microsoft.com",
|
|
"nuget.org",
|
|
"blazor.net",
|
|
// Mobile
|
|
"reactnative.dev",
|
|
"docs.flutter.dev",
|
|
"developer.apple.com",
|
|
"developer.android.com",
|
|
// Data science / ML
|
|
"keras.io",
|
|
"spark.apache.org",
|
|
"huggingface.co",
|
|
"www.kaggle.com",
|
|
// Databases
|
|
"redis.io",
|
|
"www.postgresql.org",
|
|
"dev.mysql.com",
|
|
"www.sqlite.org",
|
|
"graphql.org",
|
|
"prisma.io",
|
|
// Cloud and DevOps
|
|
"docs.aws.amazon.com",
|
|
"cloud.google.com",
|
|
"kubernetes.io",
|
|
"www.docker.com",
|
|
"www.terraform.io",
|
|
"www.ansible.com",
|
|
"vercel.com/docs",
|
|
"docs.netlify.com",
|
|
"devcenter.heroku.com",
|
|
// Testing and monitoring
|
|
"cypress.io",
|
|
"selenium.dev",
|
|
// Game development
|
|
"docs.unity.com",
|
|
"docs.unrealengine.com",
|
|
// Other tools
|
|
"git-scm.com",
|
|
"nginx.org",
|
|
"httpd.apache.org",
|
|
];
|