Files
Kigi-CLI/crates/codegen/kigi-sampler/src/events.rs
T
ZacharyZhang-NY a02b555e66 docs(comments): rewrite comments across all crates to the guidelines
Sweep every first-party crate source (1956 .rs files) to the project comment
guidelines: delete redundant restatements, decorative banners, change
narration, and end-of-line comments; keep and tighten the crucial ones
(invariants, bug rationale, SAFETY blocks, ported-source attribution).

No functional code changed. Every edit is proven comment-only against the
prior tree by a comment-stripping lexer (string/char/raw-string aware) plus a
separate doctest-fence check. Where removing a comment made rustfmt or clippy
want to re-lay-out adjacent code, the minimal triggering comment is restored so
code tokens stay byte-identical.

Gates green: cargo fmt --all --check (0 diffs), cargo check and cargo clippy
--workspace --all-targets (0 warnings).

Adds scripts/check_codegen_comment_guidelines.py — the enforcement gate for
these guidelines (flags banners, end-of-line comments, change narration, and
commented-out code).
2026-07-23 16:55:39 -04:00

365 lines
13 KiB
Rust

//! Outbound events emitted by the sampler.
use serde::{Deserialize, Serialize};
use kigi_sampling_types::{
ConversationResponse, EmptyResponseContext, ResponseModelMetadata, SamplingError,
};
use crate::metrics::InferenceLatencyStats;
use crate::types::RequestId;
/// Which content channel a token belongs to.
///
/// Extensible — adding a new channel (e.g., `Planning`) only requires a
/// new variant here, not new [`SamplingEvent`] variants. Mirrors the
/// agentic-sampler's `AgentChannel` pattern.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub enum SamplingChannel {
Text,
Reasoning,
}
/// Events emitted by the sampler for a single in-flight request.
///
/// Sent on the shared event channel that callers subscribe to. The
/// session translates these into ACP notifications.
#[derive(Debug, Clone)]
pub enum SamplingEvent {
/// HTTP stream established, headers read. Emitted before any content.
StreamStarted {
request_id: RequestId,
timestamp_ms: i64,
},
/// First content token received for a request.
FirstToken { request_id: RequestId },
/// Content token in a named channel (text or reasoning).
ChannelToken {
request_id: RequestId,
channel: SamplingChannel,
text: String,
chunk_index: u64,
},
/// Streaming delta carrying a fragment of a tool call.
///
/// Emitted by the L2 transforms (Chat Completions, Responses, Messages)
/// per-chunk as the model streams tool-call arguments. Any single
/// `arguments_delta` is NOT necessarily valid JSON in isolation.
ToolCallDelta {
request_id: RequestId,
tool_index: u32,
id: Option<String>,
name: Option<String>,
arguments_delta: Option<String>,
},
/// Streaming completed successfully.
Completed {
request_id: RequestId,
response: Box<ConversationResponse>,
metrics: InferenceLatencyStats,
},
/// Request is being retried.
Retrying {
request_id: RequestId,
attempt: u32,
max_retries: u32,
/// Typed retry class so consumers never have to sniff `reason`
/// (e.g. the shell's doom-loop recovery counter).
kind: SamplingErrorKind,
reason: String,
/// Doom-loop telemetry payload when `kind == DoomLoopDetected`:
/// raw trigger labels + the chunk index the mid-stream abort fired
/// at (`None` for terminal-response detections). Labels only.
doom_loop_triggers: Option<Vec<String>>,
doom_loop_aborted_at_chunk: Option<u64>,
},
/// Request failed (after exhausting retries or non-retryable error).
Failed {
request_id: RequestId,
error: SamplingErrorInfo,
},
/// Model metadata received from response headers.
ModelMetadata {
request_id: RequestId,
metadata: ResponseModelMetadata,
},
/// A backend-hosted tool call has started execution on the server
/// (e.g., web search is in progress). The client does NOT execute
/// these — the backend's agentic sampler handles them.
BackendToolCallStarted {
request_id: RequestId,
call_id: String,
name: String,
},
/// A backend-hosted tool call has completed execution on the server.
BackendToolCallCompleted {
request_id: RequestId,
call_id: String,
name: String,
/// Structured result data from the backend tool (tool-specific).
/// For web search: `{"query": "...", "sources": [{"url": "..."}, ...]}`
result: Option<serde_json::Value>,
},
}
/// Serializable mirror of [`SamplingError`].
///
/// The rich `SamplingError` carries non-serializable inner values
/// (`reqwest::Error`, `serde_json::Error`) so it cannot cross a network
/// boundary. `SamplingErrorInfo` extracts the bits that downstream
/// consumers (UIs, gRPC adapters) actually need.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct SamplingErrorInfo {
pub kind: SamplingErrorKind,
pub status_code: Option<u16>,
pub message: String,
pub is_retryable: bool,
pub retry_after_secs: Option<u64>,
pub model_metadata: Option<ResponseModelMetadata>,
/// Present only when `kind == EmptyResponse`. Carries the structured
/// context from the L2 stream so downstream consumers can distinguish
/// reasoning-only completions from transport failures.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub empty_response_context: Option<EmptyResponseContext>,
/// Present only when `kind == DoomLoopDetected`. Raw trigger labels
/// (never generation content) so the retry loop can reconstruct the
/// rich error from a synthesized L2 failure.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub doom_loop_triggers: Option<Vec<String>>,
/// Stream chunk index the mid-stream doom-loop abort fired at.
/// Telemetry only; `None` for terminal-response detections.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub doom_loop_aborted_at_chunk: Option<u64>,
}
/// Coarse-grained classification of a sampling failure.
///
/// Deliberately narrow — context-window-exceeded does NOT have its own
/// variant because the sampler cannot reliably detect it (it lacks
/// tracked token counts). Context-window errors arrive as
/// `Api { status: 400, .. }` with model metadata; the session inspects
/// the metadata and decides whether to compact.
#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq)]
pub enum SamplingErrorKind {
Auth,
Http,
Api,
Serialization,
IdleTimeout,
RateLimited,
EmptyResponse,
MaxTokensTruncation,
DoomLoopDetected,
}
impl SamplingErrorKind {
/// Stable, lowercase string form suitable for telemetry tags
/// (e.g., analytics `error_type` columns and signals histograms).
/// Mirrors the strings used in the shell's
/// `stream_conversation_with_retries` error classifier so tags stay
/// consistent across surfaces.
pub fn as_str(self) -> &'static str {
match self {
SamplingErrorKind::Auth => "auth",
SamplingErrorKind::Http => "http",
SamplingErrorKind::Api => "api",
SamplingErrorKind::Serialization => "serialization",
SamplingErrorKind::IdleTimeout => "idle_timeout",
SamplingErrorKind::RateLimited => "rate_limited",
SamplingErrorKind::EmptyResponse => "empty_response",
SamplingErrorKind::MaxTokensTruncation => "max_tokens_truncation",
SamplingErrorKind::DoomLoopDetected => "doom_loop_detected",
}
}
}
impl From<&SamplingError> for SamplingErrorInfo {
fn from(err: &SamplingError) -> Self {
let is_retryable = err.is_retryable();
let message = err.to_string();
let (kind, status_code, retry_after_secs, model_metadata) = match err {
SamplingError::Auth(_) => (SamplingErrorKind::Auth, None, None, None),
SamplingError::InvalidConfiguration(_) => (SamplingErrorKind::Api, None, None, None),
SamplingError::Http(_) => (SamplingErrorKind::Http, None, None, None),
SamplingError::Serialization(_) => (SamplingErrorKind::Serialization, None, None, None),
SamplingError::Api {
status,
model_metadata,
retry_after_secs,
..
} => {
let kind = if err.is_rate_limited() {
SamplingErrorKind::RateLimited
} else {
SamplingErrorKind::Api
};
(
kind,
Some(status.as_u16()),
*retry_after_secs,
model_metadata.clone(),
)
}
SamplingError::EventStreamError(_) => (SamplingErrorKind::Http, None, None, None),
SamplingError::StreamError { .. } => (SamplingErrorKind::Api, None, None, None),
SamplingError::IdleTimeout { .. } => (SamplingErrorKind::IdleTimeout, None, None, None),
SamplingError::EmptyResponse { .. } => {
(SamplingErrorKind::EmptyResponse, None, None, None)
}
SamplingError::MaxTokensTruncation => {
(SamplingErrorKind::MaxTokensTruncation, None, None, None)
}
SamplingError::DoomLoopDetected { .. } => {
(SamplingErrorKind::DoomLoopDetected, None, None, None)
}
};
let empty_response_context = match err {
SamplingError::EmptyResponse { context } => Some(context.clone()),
_ => None,
};
let (doom_loop_triggers, doom_loop_aborted_at_chunk) = match err {
SamplingError::DoomLoopDetected {
triggers,
aborted_at_chunk,
} => (Some(triggers.clone()), *aborted_at_chunk),
_ => (None, None),
};
Self {
kind,
status_code,
message,
is_retryable,
retry_after_secs,
model_metadata,
empty_response_context,
doom_loop_triggers,
doom_loop_aborted_at_chunk,
}
}
}
#[cfg(test)]
mod tests {
use super::*;
use reqwest::StatusCode;
#[test]
fn auth_variant_classified_as_auth() {
let err = SamplingError::Auth("bad token".into());
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Auth);
assert_eq!(info.status_code, None);
assert!(!info.is_retryable);
assert_eq!(info.retry_after_secs, None);
assert!(info.model_metadata.is_none());
assert!(info.message.contains("bad token"));
}
#[test]
fn invalid_configuration_classified_as_api() {
let err = SamplingError::InvalidConfiguration("missing model");
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Api);
assert_eq!(info.status_code, None);
assert!(!info.is_retryable);
}
#[test]
fn serialization_variant_classified_as_serialization() {
let json_err = serde_json::from_str::<i32>("not a number").unwrap_err();
let err: SamplingError = json_err.into();
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Serialization);
assert!(!info.is_retryable);
}
#[test]
fn api_500_classified_as_api_and_retryable() {
let err = SamplingError::Api {
status: StatusCode::INTERNAL_SERVER_ERROR,
message: "boom".into(),
model_metadata: None,
retry_after_secs: None,
};
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Api);
assert_eq!(info.status_code, Some(500));
assert!(info.is_retryable, "5xx should be retryable");
}
#[test]
fn api_429_classified_as_rate_limited_and_extracts_retry_after() {
let err = SamplingError::Api {
status: StatusCode::TOO_MANY_REQUESTS,
message: "slow down".into(),
model_metadata: None,
retry_after_secs: Some(15),
};
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::RateLimited);
assert_eq!(info.status_code, Some(429));
assert_eq!(info.retry_after_secs, Some(15));
assert!(info.is_retryable, "429 should be retryable");
}
#[test]
fn api_400_classified_as_api_and_not_retryable() {
let err = SamplingError::Api {
status: StatusCode::BAD_REQUEST,
message: "context window exceeded".into(),
model_metadata: Some(ResponseModelMetadata {
context_window: Some(8000),
..Default::default()
}),
retry_after_secs: None,
};
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Api);
assert_eq!(info.status_code, Some(400));
assert!(!info.is_retryable, "4xx (non-429) should not be retryable");
let metadata = info.model_metadata.expect("metadata preserved");
assert_eq!(metadata.context_window, Some(8000));
}
#[test]
fn event_stream_error_classified_as_http_and_retryable() {
let err = SamplingError::EventStreamError("conn reset".into());
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Http);
assert!(info.is_retryable);
}
#[test]
fn stream_error_classified_as_api_and_retryable() {
let err = SamplingError::StreamError {
error_type: "server_error".into(),
message: "transient".into(),
};
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::Api);
assert_eq!(info.status_code, None);
assert!(info.is_retryable, "stream errors should be retryable");
}
#[test]
fn idle_timeout_classified_as_idle_timeout_and_not_retryable() {
let err = SamplingError::IdleTimeout { elapsed_secs: 300 };
let info = SamplingErrorInfo::from(&err);
assert_eq!(info.kind, SamplingErrorKind::IdleTimeout);
assert!(!info.is_retryable);
assert!(info.message.contains("300s"));
}
}