Sweep every first-party crate source (1956 .rs files) to the project comment guidelines: delete redundant restatements, decorative banners, change narration, and end-of-line comments; keep and tighten the crucial ones (invariants, bug rationale, SAFETY blocks, ported-source attribution). No functional code changed. Every edit is proven comment-only against the prior tree by a comment-stripping lexer (string/char/raw-string aware) plus a separate doctest-fence check. Where removing a comment made rustfmt or clippy want to re-lay-out adjacent code, the minimal triggering comment is restored so code tokens stay byte-identical. Gates green: cargo fmt --all --check (0 diffs), cargo check and cargo clippy --workspace --all-targets (0 warnings). Adds scripts/check_codegen_comment_guidelines.py — the enforcement gate for these guidelines (flags banners, end-of-line comments, change narration, and commented-out code).
158 lines
5.1 KiB
Rust
158 lines
5.1 KiB
Rust
//! Tip of the Day — selection logic for tips served from remote settings.
|
|
//!
|
|
//! Tips are fetched at startup via `RemoteSettings.tips` (from `/v1/settings`).
|
|
//! This module provides per-session rotation: each launch shows the next tip
|
|
//! in sequence, cycling through all tips before repeating. The cursor is
|
|
//! persisted to `~/.kigi/tip_cursor.json`.
|
|
|
|
use std::path::{Path, PathBuf};
|
|
|
|
use serde::{Deserialize, Serialize};
|
|
|
|
const CURSOR_FILE: &str = "tip_cursor.json";
|
|
|
|
/// Persistent state for tip rotation.
|
|
#[derive(Debug, Default, Serialize, Deserialize)]
|
|
struct TipState {
|
|
cursor: u64,
|
|
}
|
|
|
|
fn cursor_path(kigi_home: &Path) -> PathBuf {
|
|
kigi_home.join(CURSOR_FILE)
|
|
}
|
|
|
|
/// Load the cursor from `~/.kigi/tip_cursor.json`. Returns 0 on any error.
|
|
fn load_cursor(kigi_home: &Path) -> u64 {
|
|
let text = match std::fs::read_to_string(cursor_path(kigi_home)) {
|
|
Ok(t) => t,
|
|
Err(_) => return 0,
|
|
};
|
|
serde_json::from_str::<TipState>(&text)
|
|
.map(|s| s.cursor)
|
|
.unwrap_or(0)
|
|
}
|
|
|
|
/// Save the cursor to `~/.kigi/tip_cursor.json`. Silently ignores write errors.
|
|
fn save_cursor(kigi_home: &Path, cursor: u64) {
|
|
if let Ok(text) = serde_json::to_string(&TipState { cursor }) {
|
|
let _ = std::fs::write(cursor_path(kigi_home), text);
|
|
}
|
|
}
|
|
|
|
/// Pick the next tip for this session and advance the persistent cursor.
|
|
///
|
|
/// Each call returns the tip at `cursor % tips.len()` and increments the
|
|
/// cursor in `~/.kigi/tip_cursor.json`, so every session sees the next tip
|
|
/// in sequence. After all tips have been shown, the cycle repeats.
|
|
///
|
|
/// Returns `None` if `tips` is empty (cursor is not advanced in that case).
|
|
pub fn pick_and_advance(tips: &[String], kigi_home: &Path) -> Option<String> {
|
|
if tips.is_empty() {
|
|
return None;
|
|
}
|
|
let cursor = load_cursor(kigi_home);
|
|
let tip = tips[cursor as usize % tips.len()].clone();
|
|
save_cursor(kigi_home, cursor + 1);
|
|
Some(tip)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
// pick_and_advance
|
|
|
|
#[test]
|
|
fn empty_list_returns_none() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
assert_eq!(pick_and_advance(&[], dir.path()), None);
|
|
}
|
|
|
|
#[test]
|
|
fn empty_list_does_not_advance_cursor() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
pick_and_advance(&[], dir.path());
|
|
assert_eq!(load_cursor(dir.path()), 0);
|
|
}
|
|
|
|
#[test]
|
|
fn single_tip_always_returned() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
let tips = vec!["only".to_string()];
|
|
assert_eq!(pick_and_advance(&tips, dir.path()).as_deref(), Some("only"));
|
|
assert_eq!(pick_and_advance(&tips, dir.path()).as_deref(), Some("only"));
|
|
}
|
|
|
|
#[test]
|
|
fn cycles_through_all_tips_in_order() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
let tips = vec!["a".to_string(), "b".to_string(), "c".to_string()];
|
|
assert_eq!(pick_and_advance(&tips, dir.path()).as_deref(), Some("a"));
|
|
assert_eq!(pick_and_advance(&tips, dir.path()).as_deref(), Some("b"));
|
|
assert_eq!(pick_and_advance(&tips, dir.path()).as_deref(), Some("c"));
|
|
// full cycle: wraps back to first
|
|
assert_eq!(pick_and_advance(&tips, dir.path()).as_deref(), Some("a"));
|
|
}
|
|
|
|
#[test]
|
|
fn cursor_persists_across_calls() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
let tips = vec!["x".to_string(), "y".to_string()];
|
|
// cursor → 1
|
|
pick_and_advance(&tips, dir.path());
|
|
assert_eq!(load_cursor(dir.path()), 1);
|
|
// cursor → 2
|
|
pick_and_advance(&tips, dir.path());
|
|
assert_eq!(load_cursor(dir.path()), 2);
|
|
}
|
|
|
|
#[test]
|
|
fn missing_cursor_file_starts_at_zero() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
let tips = vec!["first".to_string(), "second".to_string()];
|
|
assert_eq!(
|
|
pick_and_advance(&tips, dir.path()).as_deref(),
|
|
Some("first")
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn handles_list_length_change_gracefully() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
// Start with 3 tips, advance cursor to 3
|
|
let tips3 = vec!["a".to_string(), "b".to_string(), "c".to_string()];
|
|
// cursor 0 → 1
|
|
pick_and_advance(&tips3, dir.path());
|
|
// cursor 1 → 2
|
|
pick_and_advance(&tips3, dir.path());
|
|
// cursor 2 → 3
|
|
pick_and_advance(&tips3, dir.path());
|
|
|
|
// remote settings pushes a 5-tip list; cursor=3, 3%5=3 → "d"
|
|
let tips5 = vec![
|
|
"a".to_string(),
|
|
"b".to_string(),
|
|
"c".to_string(),
|
|
"d".to_string(),
|
|
"e".to_string(),
|
|
];
|
|
assert_eq!(pick_and_advance(&tips5, dir.path()).as_deref(), Some("d"));
|
|
}
|
|
|
|
// load_cursor / save_cursor
|
|
|
|
#[test]
|
|
fn load_cursor_returns_zero_for_corrupt_file() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
std::fs::write(cursor_path(dir.path()), b"not json").unwrap();
|
|
assert_eq!(load_cursor(dir.path()), 0);
|
|
}
|
|
|
|
#[test]
|
|
fn save_and_load_roundtrip() {
|
|
let dir = tempfile::tempdir().unwrap();
|
|
save_cursor(dir.path(), 42);
|
|
assert_eq!(load_cursor(dir.path()), 42);
|
|
}
|
|
}
|