Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
bc716d27be
commit
bcce34cda1
603 files changed
+1366
-1277
No files matched your search
@@ -29,7 +29,7 @@ type ConversationDrag struct{ ID string }
|
||||
|
||||
// ConversationItemView is a built ConversationItem and its requests.
|
||||
type ConversationItemView struct {
|
||||
Element *ui.Element
|
||||
Element ui.Element
|
||||
// Opened, Deleted, Exported and PinToggled are requests for the caller.
|
||||
Opened, Deleted, Exported, PinToggled bool
|
||||
// Renamed reports a confirmed new title, already in conv.Title.
|
||||
@@ -54,7 +54,7 @@ func ConversationItem(c *ui.Context, conv *ChatConversation, opts ConversationIt
|
||||
if today.IsZero() {
|
||||
today = core.DateOf(c.Now())
|
||||
}
|
||||
row := ui.Row(c).Key(conv.ID).FillWidth().MinHeight(d.ControlHeight()).Gap(d.Unit()).AlignItems(ui.Center).
|
||||
row := ui.Row(c.Key(conv.ID)).FillWidth().MinHeight(d.ControlHeight()).Gap(d.Unit()).AlignItems(ui.Center).
|
||||
Radius(theme.ControlRadius).Disabled(opts.Disabled)
|
||||
v := ConversationItemView{Element: row}
|
||||
st := ui.Local(row, conversationItemKey{}, func() conversationItemState { return conversationItemState{} })
|
||||
@@ -145,7 +145,7 @@ func conversationItemEditor(c *ui.Context, k theme.Tokens, conv *ChatConversatio
|
||||
}
|
||||
|
||||
// conversationItemMenu is a borderless ellipsis button opening a menu.
|
||||
func conversationItemMenu(c *ui.Context, label string, build func(m *overlay.PopupMenu)) *ui.Element {
|
||||
func conversationItemMenu(c *ui.Context, label string, build func(m *overlay.PopupMenu)) ui.Element {
|
||||
b := core.IconAction(c, icons.Must("ellipsis"), label).Role(ui.RoleMenuButton).Shrink(0)
|
||||
open := ui.Local(b, conversationItemKey{}, func() bool { return false })
|
||||
if b.IsDisabled() {
|
||||
|
||||
Reference in new issue
Block a user