Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
bc716d27be
commit
bcce34cda1
603 files changed
+1366
-1277
No files matched your search
+5
-5
@@ -26,7 +26,7 @@ type ImageOptions struct {
|
||||
|
||||
// ImageView is a shown Image and this frame's events.
|
||||
type ImageView struct {
|
||||
Element *ui.Element
|
||||
Element ui.Element
|
||||
// Retry reports the error state's retry button was pressed.
|
||||
Retry bool
|
||||
}
|
||||
@@ -46,7 +46,7 @@ func Image(c *ui.Context, src ui.ImageSource, opts ImageOptions) ImageView {
|
||||
}
|
||||
loaded := opts.Err == nil && !opts.Loading && src != nil
|
||||
var v ImageView
|
||||
v.Element = imageSized(c, src, opts, func(box, pic *ui.Element) {
|
||||
v.Element = imageSized(c, src, opts, func(box, pic ui.Element) {
|
||||
if loaded {
|
||||
if opts.Alt != "" {
|
||||
pic.Label(opts.Alt)
|
||||
@@ -60,7 +60,7 @@ func Image(c *ui.Context, src ui.ImageSource, opts ImageOptions) ImageView {
|
||||
}
|
||||
|
||||
// imageLayers builds the state layers over the hidden picture.
|
||||
func imageLayers(c *ui.Context, box *ui.Element, opts ImageOptions) (retry bool) {
|
||||
func imageLayers(c *ui.Context, box ui.Element, opts ImageOptions) (retry bool) {
|
||||
k := core.Tokens(c)
|
||||
u := core.Density(c).Unit()
|
||||
room := box.Bounds()
|
||||
@@ -99,7 +99,7 @@ func imageLayers(c *ui.Context, box *ui.Element, opts ImageOptions) (retry bool)
|
||||
}
|
||||
|
||||
// imageSized builds the outer box and its picture, sized alike in every state.
|
||||
func imageSized(c *ui.Context, src ui.ImageSource, opts ImageOptions, layers func(box, pic *ui.Element)) *ui.Element {
|
||||
func imageSized(c *ui.Context, src ui.ImageSource, opts ImageOptions, layers func(box, pic ui.Element)) ui.Element {
|
||||
if src == nil {
|
||||
src = imageBlank
|
||||
}
|
||||
@@ -123,7 +123,7 @@ func imageSized(c *ui.Context, src ui.ImageSource, opts ImageOptions, layers fun
|
||||
}
|
||||
|
||||
// imageRetry is the 28 DIP icon-only retry button.
|
||||
func imageRetry(c *ui.Context, k theme.Tokens, problem string) *ui.Element {
|
||||
func imageRetry(c *ui.Context, k theme.Tokens, problem string) ui.Element {
|
||||
b := ui.ButtonBase(c).Size(theme.MinHitSize, theme.MinHitSize).Shrink(0).Radius(theme.ControlRadius).
|
||||
Label(core.Msg(c, "image.retry")).Description(problem).Tooltip(problem)
|
||||
bg := k.Surface
|
||||
|
||||
Reference in new issue
Block a user