Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
bc716d27be
commit
bcce34cda1
603 files changed
+1366
-1277
No files matched your search
+3
-3
@@ -24,7 +24,7 @@ type TagOptions struct {
|
||||
|
||||
// TagView is a shown Tag and this frame's events.
|
||||
type TagView struct {
|
||||
Element *ui.Element
|
||||
Element ui.Element
|
||||
// Clicked reports the label was activated, not the remove button.
|
||||
Clicked bool
|
||||
// Closed reports the remove button, Delete or Backspace.
|
||||
@@ -43,7 +43,7 @@ func Tag(c *ui.Context, label string, opts TagOptions) TagView {
|
||||
Background(k.Surface).Border(theme.BorderWidth, k.Border).Shrink(0).Disabled(opts.Disabled)
|
||||
v.Element = box
|
||||
box.Children(func() {
|
||||
var main *ui.Element
|
||||
var main ui.Element
|
||||
if opts.Clickable {
|
||||
main = ui.ButtonBase(c).Label(label)
|
||||
internal.Ring(main, k.Focus, theme.ControlRadius)
|
||||
@@ -89,7 +89,7 @@ func Tag(c *ui.Context, label string, opts TagOptions) TagView {
|
||||
return v
|
||||
}
|
||||
|
||||
func tagClose(c *ui.Context, k theme.Tokens, label string) *ui.Element {
|
||||
func tagClose(c *ui.Context, k theme.Tokens, label string) ui.Element {
|
||||
b := ui.ButtonBase(c).Size(theme.MinHitSize, theme.MinHitSize).
|
||||
Radius(theme.ControlRadius).Label(fmt.Sprintf(core.Msg(c, "tag.remove"), label))
|
||||
fg := k.TextMuted
|
||||
|
||||
Reference in new issue
Block a user