Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
bc716d27be
commit
bcce34cda1
603 files changed
+1366
-1277
No files matched your search
@@ -23,7 +23,7 @@ type RenameInlineOptions struct {
|
||||
|
||||
// RenameInlineResult is a RenameInline and its outcome in this frame.
|
||||
type RenameInlineResult struct {
|
||||
Element *ui.Element
|
||||
Element ui.Element
|
||||
// Renamed reports a saved name; Canceled reports an abandoned edit.
|
||||
Renamed, Canceled bool
|
||||
}
|
||||
@@ -104,10 +104,10 @@ func RenameInline(c *ui.Context, name *string, editing *bool, opts RenameInlineO
|
||||
*editing, st.active = false, false
|
||||
slog.Debug("mujica: rename_inline end", "renamed", res.Renamed)
|
||||
}
|
||||
ui.Box(c).Key(st.gen).Grow(1).MinWidth(0).Children(func() {
|
||||
ui.Box(c.Key(st.gen)).Grow(1).MinWidth(0).Children(func() {
|
||||
in := input.TextInput(c, &st.draft, input.TextInputOptions{Label: core.Msg(c, "rename_inline.label"), Error: st.err})
|
||||
in.Element.FillWidth()
|
||||
in.Input.AutoFocus()
|
||||
core.AutoFocus(c, in.Input)
|
||||
if in.Changed() {
|
||||
st.err = ""
|
||||
renameTyped(st, *name, opts.Folder)
|
||||
@@ -140,7 +140,7 @@ func renameCheck(c *ui.Context, name string, validate func(string) string) strin
|
||||
}
|
||||
|
||||
// renameSelection marks the stem for replacement on initial input.
|
||||
func renameSelection(c *ui.Context, in *ui.Element, st *renameState) {
|
||||
func renameSelection(c *ui.Context, in ui.Element, st *renameState) {
|
||||
k := core.Tokens(c)
|
||||
stem := renameStem(st.draft, st.folder)
|
||||
if st.stemSel && st.tail == "" {
|
||||
@@ -149,8 +149,9 @@ func renameSelection(c *ui.Context, in *ui.Element, st *renameState) {
|
||||
p.Fill(ui.Rect{X: r.X, Y: r.Y + 2, W: w, H: r.H - 4}, k.Selection, 2)
|
||||
})
|
||||
}
|
||||
disabled := in.IsDisabled()
|
||||
in.HandleInput(func(ev ui.InputEvent) bool {
|
||||
if !st.stemSel || in.IsDisabled() {
|
||||
if !st.stemSel || disabled {
|
||||
return false
|
||||
}
|
||||
switch {
|
||||
|
||||
Reference in new issue
Block a user