Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
bc716d27be
commit
bcce34cda1
603 files changed
+1366
-1277
No files matched your search
+10
-5
@@ -62,6 +62,7 @@ type cascaderState struct {
|
||||
requested map[string]bool
|
||||
focus []string
|
||||
focusSet bool
|
||||
settling bool // the popup opened this frame; MyGo records its opener before rows take focus
|
||||
}
|
||||
|
||||
type cascaderKey struct{}
|
||||
@@ -84,7 +85,7 @@ func Cascader(c *ui.Context, path *[]string, opts CascaderOptions) core.ChoiceRe
|
||||
st.open = !st.open
|
||||
if st.open {
|
||||
st.active = slices.Clone(*path)
|
||||
st.focus, st.focusSet = slices.Clone(*path), true
|
||||
st.focus, st.focusSet, st.settling = slices.Clone(*path), true, true
|
||||
if len(*path) == 0 {
|
||||
st.focus = []string{""}
|
||||
}
|
||||
@@ -97,7 +98,7 @@ func Cascader(c *ui.Context, path *[]string, opts CascaderOptions) core.ChoiceRe
|
||||
}
|
||||
ui.Text(c, cascaderLabels(opts, *path)).SingleLine().Grow(1).Shrink(1)
|
||||
})
|
||||
ui.PopoverBase(c, tr, &st.open, func(panel *ui.Element) {
|
||||
ui.PopoverBase(c, tr, &st.open, func(panel ui.Element) {
|
||||
SelectPanel(c, panel)
|
||||
panel.Padding(0)
|
||||
ui.Row(c).AlignItems(ui.Stretch).Dividers(theme.BorderWidth, core.Tokens(c).Border).Children(func() {
|
||||
@@ -108,6 +109,10 @@ func Cascader(c *ui.Context, path *[]string, opts CascaderOptions) core.ChoiceRe
|
||||
}
|
||||
})
|
||||
})
|
||||
if st.settling {
|
||||
st.settling = false
|
||||
c.Invalidate()
|
||||
}
|
||||
changed := !slices.Equal(before, *path)
|
||||
if changed {
|
||||
slog.Debug("mujica: cascader changed", "label", opts.Label, "path", *path)
|
||||
@@ -147,7 +152,7 @@ func cascaderColumn(c *ui.Context, st *cascaderState, path *[]string, opts Casca
|
||||
delete(st.requested, id)
|
||||
}
|
||||
deeper := false
|
||||
col := ui.Column(c).Key(id).Width(180).FocusGroup(ui.Vertical)
|
||||
col := ui.Column(c.Key(id)).Width(180).FocusGroup(ui.Vertical)
|
||||
col.Children(func() {
|
||||
switch {
|
||||
case lv.Status == CascaderIdle || lv.Status == CascaderLoading:
|
||||
@@ -188,10 +193,10 @@ func cascaderRow(c *ui.Context, st *cascaderState, path *[]string, opts Cascader
|
||||
d := core.Density(c)
|
||||
full := append(slices.Clone(prefix), n.Value)
|
||||
depth := len(prefix)
|
||||
b := ui.ButtonBase(c).Key(n.Value).Disabled(n.Disabled).MinHeight(d.ControlHeight()).Padding(0, d.Unit()*2).
|
||||
b := ui.ButtonBase(c.Key(n.Value)).Disabled(n.Disabled).MinHeight(d.ControlHeight()).Padding(0, d.Unit()*2).
|
||||
Gap(d.Unit() * 2).Justify(ui.Start).Radius(theme.ControlRadius).FillWidth().Role(ui.RoleListItem)
|
||||
internal.Ring(b, k.Focus, theme.ControlRadius)
|
||||
if st.focusSet && (slices.Equal(st.focus, full) || first && slices.Equal(st.focus, append(slices.Clone(prefix), ""))) {
|
||||
if st.focusSet && !st.settling && (slices.Equal(st.focus, full) || first && slices.Equal(st.focus, append(slices.Clone(prefix), ""))) {
|
||||
b.Focus()
|
||||
st.focusSet = false
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user