Upgrade MyGo to v0.5.5

MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:

- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
  elements expire and Context methods are inert: read IsDisabled into a
  local during the build, keep a ui.Handle for Focus, use c.Services()
  for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
  content builds, so same-frame autofocus lost focus restore on close.
  It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
  c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
  split button tooltip no longer reorders its open menu; disabled
  menubar rows pass presses to the panel; Form defers blur-started
  async checks so the growing message no longer moves Submit away
  from the release; Combobox drops its disabled copy now that MyGo
  blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
  time.Sleep/time.Now and read element state inside the view. The web
  mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.

Snapshot goldens are darwin-only and were not re-verified here.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
ZacharyZhang-NYandClaude Opus 5.5 committed 2026-10-17 01:37:54 -04:00
1 parent bc716d27be
commit bcce34cda1
603 files changed
+1366 -1277

No files matched your search

+6 -7
View File
@@ -12,10 +12,10 @@ import (
func TestMicLevelMeterPeakHold(t *testing.T) {
level := float32(1)
var e *ui.Element
var desc string
tt := ui.NewTester(func(c *ui.Context) {
core.Use(c, core.Settings{})
e = MicLevelMeter(c, level, MicLevelMeterOptions{Hold: 40 * time.Millisecond})
desc = micTestDescription(MicLevelMeter(c, level, MicLevelMeterOptions{Hold: 40 * time.Millisecond}))
}, 400, 100)
if !tt.HasText("0 dB") {
t.Fatalf("texts %v", tt.Texts())
@@ -28,18 +28,17 @@ func TestMicLevelMeterPeakHold(t *testing.T) {
if r, ok := tt.Find("Microphone level"); !ok || r.W == 0 {
t.Fatal("meter not named")
}
if !strings.Contains(micTestDescription(e), "peak 0 dB") {
if !strings.Contains(desc, "peak 0 dB") {
t.Fatal("peak not held")
}
time.Sleep(60 * time.Millisecond)
tt.Frame()
if !strings.Contains(micTestDescription(e), "peak -20 dB") {
tt.Advance(60 * time.Millisecond)
if !strings.Contains(desc, "peak -20 dB") {
t.Fatal("peak did not fall after the hold")
}
}
// micTestDescription rebuilds the meter's spoken value from its state.
func micTestDescription(e *ui.Element) string {
func micTestDescription(e ui.Element) string {
pk := *ui.Local(e, micPeak{}, func() micPeak { return micPeak{} })
return "peak " + micDB(pk.level)
}