Upgrade MyGo to v0.5.5
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
bc716d27be
commit
bcce34cda1
603 files changed
+1366
-1277
No files matched your search
@@ -28,8 +28,8 @@ type hoverCardState struct {
|
||||
}
|
||||
|
||||
// HoverCard previews content by a hovered or focused anchor; nil while hidden.
|
||||
func HoverCard(c *ui.Context, anchor *ui.Element, opts HoverCardOptions, content func()) *ui.Element {
|
||||
if anchor == nil {
|
||||
func HoverCard(c *ui.Context, anchor ui.Element, opts HoverCardOptions, content func()) ui.Element {
|
||||
if !anchor.Valid() {
|
||||
panic("mujica: HoverCard needs an anchor")
|
||||
}
|
||||
if opts.OpenDelay < 0 || opts.CloseDelay < 0 {
|
||||
@@ -56,7 +56,7 @@ func HoverCard(c *ui.Context, anchor *ui.Element, opts HoverCardOptions, content
|
||||
st.dismissed = false
|
||||
}
|
||||
if st.dismissed {
|
||||
return nil
|
||||
return ui.Element{}
|
||||
}
|
||||
now := c.Now()
|
||||
if hot {
|
||||
@@ -67,7 +67,7 @@ func HoverCard(c *ui.Context, anchor *ui.Element, opts HoverCardOptions, content
|
||||
}
|
||||
if wait := openDelay - now.Sub(st.enterAt); wait > 0 {
|
||||
c.After(wait)
|
||||
return nil
|
||||
return ui.Element{}
|
||||
}
|
||||
slog.Debug("mujica: hover_card open", "keyboard", keyboard)
|
||||
st.open = true
|
||||
@@ -75,7 +75,7 @@ func HoverCard(c *ui.Context, anchor *ui.Element, opts HoverCardOptions, content
|
||||
} else {
|
||||
st.enterAt = time.Time{}
|
||||
if !st.open {
|
||||
return nil
|
||||
return ui.Element{}
|
||||
}
|
||||
if st.leaveAt.IsZero() {
|
||||
st.leaveAt = now
|
||||
@@ -85,7 +85,7 @@ func HoverCard(c *ui.Context, anchor *ui.Element, opts HoverCardOptions, content
|
||||
} else {
|
||||
slog.Debug("mujica: hover_card close")
|
||||
st.open, st.focusIn, st.leaveAt = false, false, time.Time{}
|
||||
return nil
|
||||
return ui.Element{}
|
||||
}
|
||||
}
|
||||
width := opts.Width
|
||||
@@ -95,7 +95,7 @@ func HoverCard(c *ui.Context, anchor *ui.Element, opts HoverCardOptions, content
|
||||
core.OverlayLayer(c, st)
|
||||
// A popover keeps the card in the anchor's focus order and modal scope, even inside a Dialog.
|
||||
shown := true
|
||||
panel := ui.PopoverBase(c, anchor, &shown, func(panel *ui.Element) {
|
||||
panel := ui.PopoverBase(c, anchor, &shown, func(panel ui.Element) {
|
||||
core.OverlayStyle(c, panel, OverlayAnchored(c, panel, b))
|
||||
panel.Margin(6, 0, 0, 0).Width(PopoverWide(c, width)).Padding(core.Density(c).Unit() * 4).Gap(core.Density(c).Unit() * 2).
|
||||
Label(opts.Label).MaxHeight(PopoverRoom(c, b))
|
||||
|
||||
Reference in new issue
Block a user