ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
91 lines
2.8 KiB
Go
91 lines
2.8 KiB
Go
package agent
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
)
|
|
|
|
// ArtifactVersion is one saved version of an artifact.
|
|
type ArtifactVersion struct {
|
|
Label string
|
|
Note string
|
|
}
|
|
|
|
// ArtifactVersionSwitcherOptions configure an ArtifactVersionSwitcher.
|
|
type ArtifactVersionSwitcherOptions struct {
|
|
Disabled bool
|
|
}
|
|
|
|
// ArtifactVersionResult reports this frame's events.
|
|
type ArtifactVersionResult struct {
|
|
Element ui.Element
|
|
// Changed reports *current moved.
|
|
Changed bool
|
|
// Compare asks to diff current against the previous version.
|
|
Compare bool
|
|
}
|
|
|
|
// ArtifactVersionSwitcher steps between artifact versions.
|
|
func ArtifactVersionSwitcher(c *ui.Context, current *int, versions []ArtifactVersion, opts ArtifactVersionSwitcherOptions) ArtifactVersionResult {
|
|
if current == nil || len(versions) == 0 || *current < 0 || *current >= len(versions) {
|
|
panic("mujica: ArtifactVersionSwitcher needs versions and a current index inside them")
|
|
}
|
|
for i, v := range versions {
|
|
if v.Label == "" {
|
|
panic(fmt.Sprintf("mujica: ArtifactVersionSwitcher version %d needs a Label", i))
|
|
}
|
|
}
|
|
u := core.Density(c).Unit()
|
|
n := len(versions)
|
|
var r ArtifactVersionResult
|
|
r.Element = ui.Row(c).Shrink(0).Gap(u * 2).AlignItems(ui.Center).Disabled(opts.Disabled).
|
|
Label(core.Msg(c, "artifact_version_switcher.label"))
|
|
locked := r.Element.IsDisabled()
|
|
move := func(d int) {
|
|
if to := *current + d; !locked && to >= 0 && to < n {
|
|
*current, r.Changed = to, true
|
|
}
|
|
}
|
|
r.Element.Children(func() {
|
|
if core.IconAction(c, icons.Must("chevron-left"), core.Msg(c, "artifact_version_switcher.older")).Disabled(locked || *current == 0).Clicked() {
|
|
move(-1)
|
|
}
|
|
v := versions[*current]
|
|
ui.Column(c).Shrink(1).Role(ui.RoleStatus).Label(v.Label).Children(func() {
|
|
ui.Row(c).Gap(u * 2).AlignItems(ui.Center).Children(func() {
|
|
ui.Text(c, v.Label).FontWeight(600).SingleLine()
|
|
AgentCaption(c, fmt.Sprintf(core.Msg(c, "artifact_version_switcher.count"), *current+1, n))
|
|
})
|
|
if v.Note != "" {
|
|
AgentCaption(c, v.Note).SingleLine()
|
|
}
|
|
})
|
|
if core.IconAction(c, icons.Must("chevron-right"), core.Msg(c, "artifact_version_switcher.newer")).Disabled(locked || *current == n-1).Clicked() {
|
|
move(1)
|
|
}
|
|
if *current > 0 {
|
|
label := fmt.Sprintf(core.Msg(c, "artifact_version_switcher.compare"), versions[*current-1].Label)
|
|
if AgentToggle(c, label, "arrow-up-down", locked) {
|
|
r.Compare = true
|
|
}
|
|
}
|
|
})
|
|
if !locked {
|
|
if r.Element.Shortcut(0, ui.KeyLeft) {
|
|
move(-1)
|
|
}
|
|
if r.Element.Shortcut(0, ui.KeyRight) {
|
|
move(1)
|
|
}
|
|
}
|
|
if r.Changed || r.Compare {
|
|
slog.Debug("mujica: artifact_version_switcher event", "current", *current, "compare", r.Compare)
|
|
}
|
|
return r
|
|
}
|