ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
58 lines
1.9 KiB
Go
58 lines
1.9 KiB
Go
package chat
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// PastedImage contains a caller-decoded clipboard or dropped image.
|
|
type PastedImage struct {
|
|
// ID is the image's stable identity; required.
|
|
ID string
|
|
Source ui.ImageSource
|
|
// Name describes it for assistive technology and the remove button.
|
|
Name string
|
|
}
|
|
|
|
// pasteImageSize is the thumbnail's edge in DIPs.
|
|
const pasteImageSize float32 = 72
|
|
|
|
// PasteImagePreview displays removable image thumbnails.
|
|
func PasteImagePreview(c *ui.Context, images []PastedImage) RemoveResult {
|
|
k := core.Tokens(c)
|
|
u := core.Density(c).Unit()
|
|
var r RemoveResult
|
|
r.Element = ui.Row(c).Gap(u * 2).Wrap().Role(ui.RoleList).Label(core.Msg(c, "paste_image_preview.label"))
|
|
disabled := r.Element.IsDisabled()
|
|
r.Element.Children(func() {
|
|
for _, im := range images {
|
|
if im.ID == "" || im.Source == nil {
|
|
panic("mujica: PastedImage needs ID and Source")
|
|
}
|
|
ui.Box(c.Key(im.ID)).Size(pasteImageSize, pasteImageSize).Role(ui.RoleListItem).Children(func() {
|
|
ui.Image(c, im.Source).Fit(ui.Cover).Size(pasteImageSize, pasteImageSize).Radius(theme.ControlRadius).
|
|
Border(theme.BorderWidth, k.Border).Label(im.Name)
|
|
x := core.IconAction(c, icons.Must("x"), fmt.Sprintf(core.Msg(c, "paste_image_preview.remove"), im.Name)).
|
|
Absolute().Top(-u * 3).Right(-u * 3).Radius(theme.MinHitSize / 2)
|
|
// A 20 DIP disc inside the 28 DIP hit area.
|
|
x.Draw(func(p *ui.Painter, r ui.Rect) {
|
|
d := ui.Rect{X: r.X + 4, Y: r.Y + 4, W: r.W - 8, H: r.H - 8}
|
|
p.Fill(d, k.Surface, d.W/2)
|
|
p.Stroke(d, k.ControlBorder, d.W/2, theme.BorderWidth)
|
|
})
|
|
if x.Clicked() && !disabled {
|
|
r.removed = im.ID
|
|
slog.Debug("mujica: paste_image_preview remove", "id", im.ID)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
return r
|
|
}
|