ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
226 lines
6.7 KiB
Go
226 lines
6.7 KiB
Go
package datetime
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
func TestTimePickerDisabledIgnoresSegmentKeys(t *testing.T) {
|
|
v, n := TimeOfDay{9, 30, 0}, 0
|
|
opts := TimePickerOptions{Label: "Alarm"}
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{Mode: core.Light})
|
|
if TimePicker(c, &v, opts).Changed() {
|
|
n++
|
|
}
|
|
}, 420, 300)
|
|
tt.Key(0, ui.KeyTab)
|
|
if !tt.Focused("Alarm: Hours") {
|
|
t.Fatal("setup: hours not focused")
|
|
}
|
|
opts.Disabled = true
|
|
tt.Frame()
|
|
tt.Key(0, ui.KeyUp)
|
|
tt.Key(0, ui.Key1)
|
|
tt.Key(0, ui.Key5)
|
|
if v != (TimeOfDay{9, 30, 0}) || n != 0 {
|
|
t.Fatalf("disabled picker took keys: %v (%d)", v, n)
|
|
}
|
|
}
|
|
|
|
func TestTimeRangePickerDisabledIgnoresSegmentKeys(t *testing.T) {
|
|
v, n := TimeRange{TimeOfDay{9, 0, 0}, TimeOfDay{17, 0, 0}}, 0
|
|
opts := TimeRangePickerOptions{}
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{Mode: core.Light})
|
|
if TimeRangePicker(c, &v, opts).Changed() {
|
|
n++
|
|
}
|
|
}, 520, 300)
|
|
_ = tt.Click("End time: Hours")
|
|
opts.Disabled = true
|
|
tt.Frame()
|
|
tt.Key(0, ui.KeyUp)
|
|
tt.Key(0, ui.KeyDown)
|
|
tt.Key(0, ui.KeyDown)
|
|
if v != (TimeRange{TimeOfDay{9, 0, 0}, TimeOfDay{17, 0, 0}}) || n != 0 {
|
|
t.Fatalf("disabled range took keys: %v (%d)", v, n)
|
|
}
|
|
}
|
|
|
|
func TestDatePickerDisabledBlurDoesNotCommit(t *testing.T) {
|
|
v, n := oct(5), 0
|
|
opts := DatePickerOptions{}
|
|
tt := datePickerLive(&v, &opts, &n)
|
|
datePickerType(tt, "Due", "2026-10-20")
|
|
opts.Disabled = true
|
|
tt.Frame()
|
|
_ = tt.Click("Open calendar")
|
|
tt.Key(0, ui.KeyTab)
|
|
tt.Frame()
|
|
if v != oct(5) || n != 0 {
|
|
t.Fatalf("disabled picker committed its draft on blur: %v (%d)", v, n)
|
|
}
|
|
}
|
|
|
|
func TestTimePickerSegmentErrorSurvivesOtherSegments(t *testing.T) {
|
|
v, n := TimeOfDay{9, 30, 0}, 0
|
|
tt := timePickerTester(&v, TimePickerOptions{}, &n)
|
|
_ = tt.Click("Alarm: Hours")
|
|
tt.Key(0, ui.Key2)
|
|
tt.Key(0, ui.Key9)
|
|
_ = tt.Click("Alarm: Minutes")
|
|
tt.Key(0, ui.KeyUp)
|
|
if !tt.HasText("29") || !tt.HasText("Hours must be from 0 to 23.") {
|
|
t.Fatalf("editing minutes cleared the hour error: %v", tt.Texts())
|
|
}
|
|
if v != (TimeOfDay{2, 30, 0}) {
|
|
t.Fatalf("value written while a segment is invalid: %v", v)
|
|
}
|
|
_ = tt.Click("Alarm: Hours")
|
|
tt.Key(0, ui.Key0)
|
|
tt.Key(0, ui.Key8)
|
|
if v != (TimeOfDay{8, 31, 0}) || tt.HasText("Hours must be") {
|
|
t.Fatalf("fixing the hour should commit both: %v", v)
|
|
}
|
|
}
|
|
|
|
func TestDateTimePickerBlocksConfirmWithInvalidSegment(t *testing.T) {
|
|
v := time.Date(2026, time.October, 5, 9, 30, 0, 0, time.UTC)
|
|
n, x := 0, 0
|
|
tt := dateTimeTester(t, &v, DateTimePickerOptions{Location: time.UTC}, &n, &x)
|
|
_ = tt.Click("Meeting")
|
|
_ = tt.Click("Time: Hours")
|
|
tt.Key(0, ui.Key2)
|
|
tt.Key(0, ui.Key9)
|
|
_ = tt.Click("Time: Minutes")
|
|
tt.Key(0, ui.KeyUp)
|
|
_ = tt.Click("Confirm")
|
|
if n != 0 || !v.Equal(time.Date(2026, time.October, 5, 9, 30, 0, 0, time.UTC)) {
|
|
t.Fatalf("confirmed with an invalid hour: %v", v)
|
|
}
|
|
if !tt.HasText("Hours must be from 0 to 23.") || !tt.HasText("Confirm") {
|
|
t.Fatalf("expected the popup to stay with the error: %v", tt.Texts())
|
|
}
|
|
}
|
|
|
|
func TestDateRangePickerConfirmChecksCurrentBounds(t *testing.T) {
|
|
v, n := DateRange{}, 0
|
|
opts := DateRangePickerOptions{}
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{Mode: core.Light})
|
|
o := opts
|
|
o.Today, o.Label = calendarToday, "Stay"
|
|
if DateRangePicker(c, &v, o).Changed() {
|
|
n++
|
|
}
|
|
}, 420, 520)
|
|
_ = tt.Click("Stay")
|
|
_ = tt.Click(datetimeTestLabel(oct(10)))
|
|
_ = tt.Click(datetimeTestLabel(oct(15)))
|
|
opts.Max = oct(12)
|
|
tt.Frame()
|
|
_ = tt.Click("Confirm")
|
|
if n != 0 || !v.IsZero() || !tt.HasText("Choose 2026-10-12 or earlier.") {
|
|
t.Fatalf("out-of-range draft committed: %v %v", v, tt.Texts())
|
|
}
|
|
opts.Max = core.Date{}
|
|
opts.DisableDate = func(d core.Date) bool { return d == oct(11) }
|
|
tt.Frame()
|
|
_ = tt.Click("Confirm")
|
|
if n != 0 || !tt.HasText("The range cannot include 2026-10-11.") {
|
|
t.Fatalf("draft over a newly disabled day committed: %v", v)
|
|
}
|
|
opts.DisableDate = nil
|
|
tt.Frame()
|
|
_ = tt.Click("Confirm")
|
|
if n != 1 || v != (DateRange{oct(10), oct(15)}) {
|
|
t.Fatalf("valid draft not committed: %v", v)
|
|
}
|
|
}
|
|
|
|
func TestTimePickerPopupPickClearsSegmentError(t *testing.T) {
|
|
v, n := TimeOfDay{9, 30, 0}, 0
|
|
tt := timePickerTester(&v, TimePickerOptions{}, &n)
|
|
_ = tt.Click("Alarm: Hours")
|
|
tt.Key(0, ui.Key2)
|
|
tt.Key(0, ui.Key9)
|
|
if v != (TimeOfDay{2, 30, 0}) || !tt.HasText("Hours must be from 0 to 23.") {
|
|
t.Fatalf("setup: %v %v", v, tt.Texts())
|
|
}
|
|
n = 0
|
|
_ = tt.Click("Choose time")
|
|
if err := tt.Click("03"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if v != (TimeOfDay{3, 30, 0}) || n != 1 || tt.HasText("Hours must be") {
|
|
t.Fatalf("popup pick: value %v, %d changes, %v", v, n, tt.Texts())
|
|
}
|
|
}
|
|
|
|
func TestFormFocusesDatePickerInput(t *testing.T) {
|
|
var st input.FormState
|
|
day := core.Date{}
|
|
focused := false
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
var field ui.Element
|
|
input.Form(c, &st, input.FormOptions{}, func(f *input.FormScope) {
|
|
input.FormItem(c, f, "debut", &day, input.FormItemOptions[core.Date]{Label: "Debut date", Required: true}, func() ui.Element {
|
|
r := DatePicker(c, &day, DatePickerOptions{Today: calendarToday})
|
|
field = r.Input
|
|
return r.Input
|
|
})
|
|
})
|
|
focused = field.Valid() && field.Focused()
|
|
}, 600, 500)
|
|
if err := tt.Click("Submit"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !focused || !tt.Focused("Debut date") {
|
|
t.Fatal("a failed submit should focus the DatePicker's text box")
|
|
}
|
|
tt.Type("2026-10-12")
|
|
tt.Key(0, ui.KeyEnter)
|
|
if day != oct(12) {
|
|
t.Fatalf("typing after the focus jump gave %v", day)
|
|
}
|
|
}
|
|
|
|
func TestSelectedCellsHaveTheirOwnMark(t *testing.T) {
|
|
k := theme.Light()
|
|
check := func(name string, tt *ui.Tester, label string, shift int) {
|
|
t.Helper()
|
|
r, ok := tt.Find(label)
|
|
if !ok {
|
|
t.Fatalf("%s: no cell %q", name, label)
|
|
}
|
|
r.X += float32(shift) * r.W
|
|
img := tt.Image()
|
|
y := int(r.Y + r.H/2)
|
|
frame, fill := img.RGBAAt(int(r.X)+2, y), img.RGBAAt(int(r.X)+5, y)
|
|
if !datetimeNear(frame, k.OnAccent) || !datetimeNear(fill, k.Accent) {
|
|
t.Fatalf("%s: selected cell frame %v fill %v", name, frame, fill)
|
|
}
|
|
}
|
|
v := oct(14)
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{Mode: core.Light})
|
|
Calendar(c, &v, CalendarOptions{Today: calendarToday})
|
|
}, 400, 400)
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
check("calendar", tt, datetimeTestLabel(oct(14)), 0)
|
|
y := 2024
|
|
ty := yearPickerTester(&y, YearPickerOptions{}, new(int))
|
|
ty.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
_ = ty.Click("Vintage")
|
|
// The field also shows "2024", so locate the cell beside 2023.
|
|
check("year", ty, "2023", 1)
|
|
}
|