ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
95 lines
3.2 KiB
Go
95 lines
3.2 KiB
Go
package devtools
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
)
|
|
|
|
// RefreshIntervalSelectorOptions configure a RefreshIntervalSelector.
|
|
type RefreshIntervalSelectorOptions struct {
|
|
// Intervals defaults to 5s, 10s, 30s, 1m and 5m.
|
|
Intervals []time.Duration
|
|
// Refreshing shows the refresh in progress and holds the timer.
|
|
Refreshing bool
|
|
Disabled bool
|
|
}
|
|
|
|
// RefreshResult reports this frame's events.
|
|
type RefreshResult struct {
|
|
Element ui.Element
|
|
// Refresh requests caller loading, manually or after the interval.
|
|
Refresh bool
|
|
// Changed reports a new interval.
|
|
Changed bool
|
|
}
|
|
|
|
type refreshState struct{ last time.Time }
|
|
|
|
var refreshDefaults = []time.Duration{5 * time.Second, 10 * time.Second, 30 * time.Second, time.Minute, 5 * time.Minute}
|
|
|
|
// RefreshIntervalSelector selects timed refresh intervals and reports manual requests.
|
|
func RefreshIntervalSelector(c *ui.Context, interval *time.Duration, opts RefreshIntervalSelectorOptions) RefreshResult {
|
|
if interval == nil {
|
|
panic("mujica: RefreshIntervalSelector needs an interval")
|
|
}
|
|
choices := opts.Intervals
|
|
if choices == nil {
|
|
choices = refreshDefaults
|
|
}
|
|
options := []input.SelectOption[time.Duration]{{Value: 0, Label: core.Msg(c, "refresh_interval_selector.off")}}
|
|
known := *interval == 0
|
|
seen := map[time.Duration]bool{}
|
|
for _, d := range choices {
|
|
if d < time.Second || d%time.Second != 0 || seen[d] {
|
|
panic("mujica: RefreshIntervalSelector intervals must be whole seconds")
|
|
}
|
|
seen[d] = true
|
|
known = known || d == *interval
|
|
label := fmt.Sprintf(core.Msg(c, "refresh_interval_selector.seconds"), int(d/time.Second))
|
|
if d%time.Minute == 0 {
|
|
label = fmt.Sprintf(core.Msg(c, "refresh_interval_selector.minutes"), int(d/time.Minute))
|
|
}
|
|
options = append(options, input.SelectOption[time.Duration]{Value: d, Label: label})
|
|
}
|
|
if !known {
|
|
panic("mujica: RefreshIntervalSelector interval is not offered")
|
|
}
|
|
u := core.Density(c).Unit()
|
|
var r RefreshResult
|
|
r.Element = ui.Row(c).Shrink(0).Gap(u * 2).AlignItems(ui.Center).Disabled(opts.Disabled)
|
|
st := ui.Local(r.Element, "mujica.refresh", func() refreshState { return refreshState{last: c.Now()} })
|
|
locked := r.Element.IsDisabled()
|
|
r.Element.Children(func() {
|
|
label := core.Msg(c, "refresh_interval_selector.refresh")
|
|
if opts.Refreshing {
|
|
core.Spinner(c, core.SpinnerOptions{Size: 14, Label: core.Msg(c, "refresh_interval_selector.refreshing")})
|
|
}
|
|
if input.Button(c, label, input.ButtonOptions{Variant: input.Secondary, Icon: icons.Must("refresh-cw"), Disabled: locked || opts.Refreshing}).Clicked() && !locked {
|
|
r.Refresh = true
|
|
}
|
|
r.Changed = input.Select(c, interval, options, input.SelectOptions{Label: core.Msg(c, "refresh_interval_selector.label"), Disabled: locked}).Changed()
|
|
})
|
|
if r.Changed || opts.Refreshing {
|
|
st.last = c.Now()
|
|
}
|
|
if *interval > 0 && !locked && !opts.Refreshing && !r.Refresh {
|
|
if wait := *interval - c.Now().Sub(st.last); wait > 0 {
|
|
c.After(wait)
|
|
} else {
|
|
r.Refresh = true
|
|
}
|
|
}
|
|
if r.Refresh {
|
|
st.last = c.Now()
|
|
slog.Debug("mujica: refresh_interval_selector refresh", "interval", *interval)
|
|
}
|
|
return r
|
|
}
|