ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
99 lines
2.3 KiB
Go
99 lines
2.3 KiB
Go
package display
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// IconTone is an icon's semantic color; zero inherits text color.
|
|
type IconTone int
|
|
|
|
const (
|
|
IconInherit IconTone = iota
|
|
IconMuted
|
|
IconAccent
|
|
IconSuccess
|
|
IconWarning
|
|
IconDanger
|
|
IconInfo
|
|
)
|
|
|
|
// IconOptions configure an Icon.
|
|
type IconOptions struct {
|
|
// Size is width and height in DIPs; zero means 16.
|
|
Size float32
|
|
Tone IconTone
|
|
// Label names the icon for assistive technology; empty hides it.
|
|
Label string
|
|
}
|
|
|
|
type iconMissingKey struct{}
|
|
|
|
// Icon shows a named icon; missing ones show a fallback.
|
|
func Icon(c *ui.Context, name string, opts IconOptions) ui.Element {
|
|
if name == "" {
|
|
panic("mujica: Icon needs a name")
|
|
}
|
|
size := opts.Size
|
|
if size < 0 {
|
|
panic("mujica: Icon Size must not be negative")
|
|
}
|
|
if size == 0 {
|
|
size = 16
|
|
}
|
|
k := core.Tokens(c)
|
|
svg, ok := icons.Get(name)
|
|
if !ok {
|
|
return iconMissing(c, name, size, k)
|
|
}
|
|
e := ui.Icon(c, svg).Size(size, size).Shrink(0)
|
|
if col, set := iconColor(k, opts.Tone); set {
|
|
e.TextColor(col)
|
|
}
|
|
if opts.Label != "" {
|
|
e.Label(opts.Label)
|
|
}
|
|
return e
|
|
}
|
|
|
|
func iconMissing(c *ui.Context, name string, size float32, k theme.Tokens) ui.Element {
|
|
text := fmt.Sprintf(core.Msg(c, "icon.missing"), name)
|
|
e := ui.Box(c).Size(size, size).Shrink(0).Role(ui.RoleImage).Label(text).Tooltip(text)
|
|
logged := ui.Local(e, iconMissingKey{}, func() string { return "" })
|
|
if *logged != name {
|
|
*logged = name
|
|
slog.Warn("mujica: icon missing", "name", name)
|
|
}
|
|
return e.Draw(func(p *ui.Painter, r ui.Rect) {
|
|
in := ui.Rect{X: r.X + 1, Y: r.Y + 1, W: r.W - 2, H: r.H - 2}
|
|
p.StrokeDashed(in, k.Danger, theme.ControlRadius, 1)
|
|
p.Line(in.X+3, in.Y+3, in.X+in.W-3, in.Y+in.H-3, 1, k.Danger)
|
|
})
|
|
}
|
|
|
|
func iconColor(k theme.Tokens, t IconTone) (ui.Color, bool) {
|
|
switch t {
|
|
case IconInherit:
|
|
return ui.Color{}, false
|
|
case IconMuted:
|
|
return k.TextMuted, true
|
|
case IconAccent:
|
|
return k.AccentText, true
|
|
case IconSuccess:
|
|
return k.Success, true
|
|
case IconWarning:
|
|
return k.Warning, true
|
|
case IconDanger:
|
|
return k.Danger, true
|
|
case IconInfo:
|
|
return k.Info, true
|
|
}
|
|
panic(fmt.Sprintf("mujica: unknown IconTone %d", t))
|
|
}
|