ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
82 lines
2.1 KiB
Go
82 lines
2.1 KiB
Go
package display
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
"net/url"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// LinkOptions configure a Link; empty URL means in-app action.
|
|
type LinkOptions struct {
|
|
// URL opens in the browser; paths go to the router.
|
|
URL string
|
|
// Error is the caller's open failure, shown below the link.
|
|
Error string
|
|
}
|
|
|
|
// Link is underlined text; malformed URLs show an error instead.
|
|
func Link(c *ui.Context, label string, opts LinkOptions) ui.Element {
|
|
if label == "" {
|
|
panic("mujica: Link needs a label")
|
|
}
|
|
k := core.Tokens(c)
|
|
u := core.Density(c).Unit()
|
|
external := false
|
|
problem := opts.Error
|
|
target := opts.URL
|
|
if opts.URL != "" {
|
|
ok := false
|
|
external, ok = linkCheck(opts.URL)
|
|
if !ok {
|
|
external, target = false, ""
|
|
if problem == "" {
|
|
problem = fmt.Sprintf(core.Msg(c, "link.invalid"), opts.URL)
|
|
}
|
|
}
|
|
}
|
|
var l ui.Element
|
|
ui.Column(c).Gap(u).AlignItems(ui.Start).Children(func() {
|
|
ui.Row(c).Gap(u).AlignItems(ui.Center).Children(func() {
|
|
l = ui.Link(c, label, target).Underline().DecorationThickness(1)
|
|
internal.Ring(l, k.Focus, theme.ControlRadius)
|
|
color := k.AccentText
|
|
if l.Pressed() || l.Hovered() {
|
|
color = k.Text
|
|
}
|
|
l.TextColor(color).DecorationColor(color)
|
|
if external {
|
|
Icon(c, "external-link", IconOptions{Size: 12, Tone: IconAccent})
|
|
}
|
|
})
|
|
if problem != "" {
|
|
l.Error(problem)
|
|
ui.Text(c, problem).TextColor(k.Danger).FontSize(core.FontSize(c, theme.CaptionSize))
|
|
}
|
|
})
|
|
if l.Clicked() {
|
|
slog.Debug("mujica: link activate", "url", opts.URL, "opened", target != "")
|
|
}
|
|
return l
|
|
}
|
|
|
|
// linkCheck reports whether raw has a scheme and is openable.
|
|
func linkCheck(raw string) (external, ok bool) {
|
|
p, err := url.Parse(raw)
|
|
if err != nil {
|
|
return false, false
|
|
}
|
|
switch p.Scheme {
|
|
case "":
|
|
return false, p.Path != "" || p.RawQuery != ""
|
|
case "http", "https":
|
|
return true, p.Host != ""
|
|
}
|
|
return true, p.Opaque != "" || p.Host != "" || p.Path != ""
|
|
}
|