ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
95 lines
2.8 KiB
Go
95 lines
2.8 KiB
Go
package feedback
|
|
|
|
import (
|
|
"cmp"
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// LoadingOverlayOptions configure a LoadingOverlay.
|
|
type LoadingOverlayOptions struct {
|
|
// Label explains the wait; empty uses "Loading…".
|
|
Label string
|
|
// Cancel labels a button that reports Canceled; empty shows none.
|
|
Cancel string
|
|
}
|
|
|
|
// LoadingOverlayResult is what a LoadingOverlay built and reported this frame.
|
|
type LoadingOverlayResult struct {
|
|
Element ui.Element
|
|
// Canceled reports the cancel button or Escape while loading.
|
|
Canceled bool
|
|
}
|
|
|
|
// LoadingOverlay covers content while loading, blocking input to that region only.
|
|
func LoadingOverlay(c *ui.Context, loading bool, opts LoadingOverlayOptions, content func()) LoadingOverlayResult {
|
|
if content == nil {
|
|
panic("mujica: LoadingOverlay needs content")
|
|
}
|
|
k := core.Tokens(c)
|
|
u := core.Density(c).Unit()
|
|
label := cmp.Or(opts.Label, core.Msg(c, "loading_overlay.label"))
|
|
var res LoadingOverlayResult
|
|
box := ui.Box(c)
|
|
was := ui.Local(box, "loading_overlay.loading", func() bool { return false })
|
|
if loading != *was {
|
|
slog.Debug("mujica: loading_overlay changed", "loading", loading)
|
|
if loading {
|
|
c.Announce(label)
|
|
}
|
|
*was = loading
|
|
}
|
|
box.Children(func() {
|
|
inner := ui.Column(c).FillWidth().Disabled(loading)
|
|
inner.Children(content)
|
|
if !loading {
|
|
return
|
|
}
|
|
held := inner.FocusWithin()
|
|
scrim := ui.Column(c).Absolute().Left(0).Top(0).Right(0).Bottom(0).Center().Padding(u * 4).
|
|
Background(k.Background.Alpha(0.5)).Radius(theme.CardRadius)
|
|
scrim.Transition(ui.ElementTransition{Duration: theme.StateDuration, Enter: &ui.Motion{}, Exit: &ui.Motion{}})
|
|
scrim.Children(func() {
|
|
panel := ui.Column(c).AlignItems(ui.Center).Gap(u*3).Padding(u*4, u*6).Radius(theme.PopupRadius).
|
|
Background(k.Surface).Border(theme.BorderWidth, k.Border).Role(ui.RoleStatus).Label(label)
|
|
if opts.Cancel == "" {
|
|
// Without a button the panel keeps the focus in the region.
|
|
internal.Ring(panel.Focusable(), k.Focus, theme.PopupRadius)
|
|
if held {
|
|
panel.Focus()
|
|
}
|
|
}
|
|
panel.Children(func() {
|
|
ui.Row(c).Gap(u * 2).AlignItems(ui.Center).Children(func() {
|
|
core.Spinner(c, core.SpinnerOptions{Size: 20, Label: label})
|
|
ui.Text(c, label).TextColor(k.Text)
|
|
})
|
|
if opts.Cancel == "" {
|
|
return
|
|
}
|
|
b := input.Button(c, opts.Cancel, input.ButtonOptions{Variant: input.Secondary})
|
|
if held {
|
|
b.Focus()
|
|
}
|
|
if b.Clicked() {
|
|
res.Canceled = true
|
|
}
|
|
})
|
|
if opts.Cancel != "" && panel.Shortcut(0, ui.KeyEscape) {
|
|
res.Canceled = true
|
|
}
|
|
})
|
|
})
|
|
if res.Canceled {
|
|
slog.Debug("mujica: loading_overlay canceled")
|
|
}
|
|
res.Element = box
|
|
return res
|
|
}
|