ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
package feedback
|
|
|
|
import (
|
|
"math"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
func TestReorderTransitionSlides(t *testing.T) {
|
|
keys := []string{"a", "b", "c"}
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
ReorderTransition(c, keys, ReorderTransitionOptions{Gap: 4}, func(k string) {
|
|
ui.Text(c, "Item "+k).Padding(8)
|
|
})
|
|
}, 300, 200)
|
|
ra, _ := tt.Find("Item a")
|
|
keys = []string{"c", "b", "a"}
|
|
before := *n
|
|
tt.Frame()
|
|
if *n-before < 3 {
|
|
t.Fatal("reorder did not animate")
|
|
}
|
|
tt.Advance(theme.StateDuration / 2)
|
|
mid, _ := tt.Find("Item a")
|
|
tt.Advance(260 * time.Millisecond)
|
|
end, _ := tt.Find("Item a")
|
|
if !(mid.Y > ra.Y && mid.Y < end.Y) || motionBusy(tt, n) {
|
|
t.Fatalf("a moved %v → %v → %v", ra.Y, mid.Y, end.Y)
|
|
}
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("duplicate key did not panic")
|
|
}
|
|
}()
|
|
ui.Render(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
ReorderTransition(c, []int{1, 1}, ReorderTransitionOptions{}, func(int) {})
|
|
}, 100, 50, 1)
|
|
}
|
|
|
|
func TestReorderTransitionSnapshot(t *testing.T) {
|
|
snapshot(t, "reorder_transition", 300, 140, func(c *ui.Context) {
|
|
ui.Column(c).Padding(16).Children(func() {
|
|
ReorderTransition(c, []string{"Sakiko", "Uika", "Mutsumi"}, ReorderTransitionOptions{Gap: 4}, func(k string) {
|
|
ui.Text(c, k).Padding(4, 8).Background(core.Tokens(c).Surface).Radius(4)
|
|
})
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestReorderTransitionInvalidGap(t *testing.T) {
|
|
for _, gap := range []float32{float32(nanValue()), float32(math.Inf(1))} {
|
|
func() {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Errorf("invalid gap %v accepted", gap)
|
|
}
|
|
}()
|
|
ui.Render(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
ReorderTransition(c, []int{1}, ReorderTransitionOptions{Gap: gap}, func(int) {})
|
|
}, 200, 100, 1)
|
|
}()
|
|
}
|
|
}
|
|
|
|
func TestReorderTransitionReducedMotionCancelsExit(t *testing.T) {
|
|
keys := []string{"a", "b"}
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
ReorderTransition(c, keys, ReorderTransitionOptions{Duration: 5 * time.Second}, func(k string) { ui.Text(c, k) })
|
|
}, 300, 150)
|
|
keys = []string{"b"}
|
|
tt.Frame()
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
if motionBusy(tt, n) || tt.HasText("a") {
|
|
t.Fatal("removed item kept animating under reduced motion")
|
|
}
|
|
}
|