ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
83 lines
2.3 KiB
Go
83 lines
2.3 KiB
Go
package feedback
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
func TestSkeletonSizes(t *testing.T) {
|
|
var text, circle, rect, fixed ui.Rect
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{Density: theme.Compact})
|
|
ui.Column(c).Width(300).AlignItems(ui.Start).Children(func() {
|
|
text = Skeleton(c, SkeletonOptions{Lines: 3}).Bounds()
|
|
circle = Skeleton(c, SkeletonOptions{Shape: SkeletonCircle}).Bounds()
|
|
rect = Skeleton(c, SkeletonOptions{Shape: SkeletonRect}).Bounds()
|
|
fixed = Skeleton(c, SkeletonOptions{Shape: SkeletonRect, Width: 120, Height: 80}).Bounds()
|
|
})
|
|
}, 400, 400)
|
|
tt.Frame()
|
|
if text.W != 300 || text.H != 63 {
|
|
t.Errorf("text %v", text)
|
|
}
|
|
if circle.W != 40 || circle.H != 40 {
|
|
t.Errorf("circle %v", circle)
|
|
}
|
|
if rect.W != 300 || rect.H != 28 {
|
|
t.Errorf("rect %v", rect)
|
|
}
|
|
if fixed.W != 120 || fixed.H != 80 {
|
|
t.Errorf("fixed %v", fixed)
|
|
}
|
|
}
|
|
|
|
func TestSkeletonStaticUnderReducedMotion(t *testing.T) {
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
Skeleton(c, SkeletonOptions{Shape: SkeletonRect})
|
|
}, 200, 100)
|
|
a := encode(t, tt.Image())
|
|
tt.Advance(300 * time.Millisecond)
|
|
if bytes.Equal(a, encode(t, tt.Image())) {
|
|
t.Fatal("skeleton did not pulse")
|
|
}
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
a = encode(t, tt.Image())
|
|
tt.Advance(300 * time.Millisecond)
|
|
if !bytes.Equal(a, encode(t, tt.Image())) {
|
|
t.Fatal("skeleton moved under reduced motion")
|
|
}
|
|
}
|
|
|
|
func TestSkeletonPanicsOnNegativeSize(t *testing.T) {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("no panic")
|
|
}
|
|
}()
|
|
ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
Skeleton(c, SkeletonOptions{Lines: -1})
|
|
}, 200, 100)
|
|
}
|
|
|
|
func TestSkeletonSnapshot(t *testing.T) {
|
|
snapshot(t, "skeleton", 420, 200, func(c *ui.Context) {
|
|
ui.Column(c).Padding(20).Gap(16).Children(func() {
|
|
ui.Row(c).Gap(12).AlignItems(ui.Center).Children(func() {
|
|
Skeleton(c, SkeletonOptions{Shape: SkeletonCircle})
|
|
ui.Column(c).Grow(1).Children(func() {
|
|
Skeleton(c, SkeletonOptions{Lines: 2})
|
|
})
|
|
})
|
|
Skeleton(c, SkeletonOptions{Shape: SkeletonRect, Height: 72})
|
|
})
|
|
})
|
|
}
|