ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
93 lines
2.6 KiB
Go
93 lines
2.6 KiB
Go
package feedback
|
|
|
|
import (
|
|
"slices"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
)
|
|
|
|
func undoTester(open *bool, life time.Duration, undos *int, last *UndoToastResult) *ui.Tester {
|
|
return ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
if input.Button(c, "Delete", input.ButtonOptions{}).Clicked() {
|
|
*open = true
|
|
}
|
|
if r := UndoToast(c, open, "File deleted", UndoToastOptions{Duration: life, OnUndo: func() { *undos++ }}); r.Undone || r.Expired {
|
|
*last = r
|
|
}
|
|
}, 600, 400)
|
|
}
|
|
|
|
func TestUndoToastUndoAndFocus(t *testing.T) {
|
|
open, undos := false, 0
|
|
var last UndoToastResult
|
|
tt := undoTester(&open, 0, &undos, &last)
|
|
tt.Key(0, ui.KeyTab)
|
|
tt.Key(0, ui.KeyEnter)
|
|
if !tt.HasText("File deleted") || !tt.HasText("Undo (5)") || !tt.Focused("Delete") {
|
|
t.Fatalf("shown %q, focus kept %v", tt.Texts(), tt.Focused("Delete"))
|
|
}
|
|
if !slices.Contains(tt.Announcements(), "File deleted") {
|
|
t.Fatal("not announced")
|
|
}
|
|
if err := tt.Click("Undo (5)"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if undos != 1 || open || !last.Undone || tt.HasText("File deleted") {
|
|
t.Fatalf("undo: %d %v %+v", undos, open, last)
|
|
}
|
|
}
|
|
|
|
func TestUndoToastCountdownPauseAndClose(t *testing.T) {
|
|
open, undos := false, 0
|
|
var last UndoToastResult
|
|
tt := undoTester(&open, 60*time.Millisecond, &undos, &last)
|
|
_ = tt.Click("Delete")
|
|
r, _ := tt.Find("File deleted")
|
|
tt.Move(r.X+r.W/2, r.Y+r.H/2)
|
|
tt.Advance(90 * time.Millisecond)
|
|
if !open {
|
|
t.Fatal("hovered countdown ran out")
|
|
}
|
|
tt.Move(5, 5)
|
|
tt.Advance(90 * time.Millisecond)
|
|
if open || !last.Expired || undos != 0 {
|
|
t.Fatalf("expiry: %v %+v %d", open, last, undos)
|
|
}
|
|
last = UndoToastResult{}
|
|
_ = tt.Click("Delete")
|
|
_ = tt.Click("Dismiss notification")
|
|
if open || !last.Expired || undos != 0 {
|
|
t.Fatalf("close: %v %+v", open, last)
|
|
}
|
|
}
|
|
|
|
func TestUndoToastRejects(t *testing.T) {
|
|
open := true
|
|
for name, f := range map[string]func(c *ui.Context){
|
|
"no undo": func(c *ui.Context) { UndoToast(c, &open, "x", UndoToastOptions{}) },
|
|
"negative": func(c *ui.Context) { UndoToast(c, &open, "x", UndoToastOptions{OnUndo: func() {}, Duration: -1}) },
|
|
} {
|
|
func() {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Errorf("%s: no panic", name)
|
|
}
|
|
}()
|
|
ui.NewTester(func(c *ui.Context) { core.Use(c, core.Settings{}); f(c) }, 300, 200)
|
|
}()
|
|
}
|
|
}
|
|
|
|
func TestUndoToastSnapshot(t *testing.T) {
|
|
open := true
|
|
snapshot(t, "undo_toast", 520, 160, func(c *ui.Context) {
|
|
UndoToast(c, &open, "3 messages archived", UndoToastOptions{OnUndo: func() {}, Duration: time.Hour})
|
|
})
|
|
}
|