ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
86 lines
2.6 KiB
Go
86 lines
2.6 KiB
Go
package input
|
|
|
|
import (
|
|
"log/slog"
|
|
"slices"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// ChoiceChipsOptions configure ChoiceChips.
|
|
type ChoiceChipsOptions struct {
|
|
// Multiple lets several chips be on; otherwise one or none.
|
|
Multiple bool
|
|
Disabled bool
|
|
// Label names the chip set for assistive technology.
|
|
Label string
|
|
}
|
|
|
|
// ChoiceChips are wrapping filter chips toggling values in *value; arrows move between them.
|
|
func ChoiceChips[T comparable](c *ui.Context, value *[]T, items []ToggleItem[T], opts ChoiceChipsOptions) core.ChoiceResult {
|
|
if value == nil {
|
|
panic("mujica: ChoiceChips needs a value")
|
|
}
|
|
if !opts.Multiple && len(*value) > 1 {
|
|
panic("mujica: single ChoiceChips holds more than one value")
|
|
}
|
|
k := core.Tokens(c)
|
|
d := core.Density(c)
|
|
g := ui.Row(c).Wrap().Gap(d.Unit() * 2).Disabled(opts.Disabled).Role(ui.RoleGroup).FocusGroup(ui.Horizontal)
|
|
if opts.Label != "" {
|
|
g.Label(opts.Label)
|
|
}
|
|
changed := false
|
|
g.Children(func() {
|
|
for _, it := range items {
|
|
on := slices.Contains(*value, it.Value)
|
|
pressed := on
|
|
b := ui.ToggleBase(c, &pressed).Disabled(it.Disabled)
|
|
// The base took input before Disabled applied: drop a disabled chip's press.
|
|
if b.Changed() && !b.IsDisabled() && toggleGroupApply(value, it.Value, pressed, ToggleGroupOptions{Multiple: opts.Multiple, AllowEmpty: true}) {
|
|
changed, on = true, pressed
|
|
}
|
|
choiceChipLook(c, k, d, b, on, it)
|
|
}
|
|
})
|
|
if changed {
|
|
slog.Debug("mujica: choice_chips changed", "label", opts.Label, "value", *value)
|
|
}
|
|
return core.NewChoiceResult(g, changed)
|
|
}
|
|
|
|
func choiceChipLook[T comparable](c *ui.Context, k theme.Tokens, d theme.Density, b ui.Element, on bool, it ToggleItem[T]) {
|
|
b.MinHeight(max(theme.MinHitSize, d.ControlHeight()-4)).MinWidth(theme.MinHitSize).Padding(0, d.Unit()*3).Gap(d.Unit() * 1.5).
|
|
Radius(theme.PopupRadius)
|
|
internal.Ring(b, k.Focus, theme.PopupRadius)
|
|
bg, fg, line := k.Surface, k.Text, k.ControlBorder
|
|
switch {
|
|
case on:
|
|
bg, fg, line = k.Selection, k.AccentText, k.AccentText
|
|
case b.Pressed():
|
|
bg = k.Selection
|
|
case b.Hovered():
|
|
bg = k.SurfaceHover
|
|
}
|
|
b.Background(bg).TextColor(fg).Border(theme.BorderWidth, line).Transition(core.ColorFade)
|
|
if it.Name != "" {
|
|
b.Label(it.Name)
|
|
}
|
|
b.Children(func() {
|
|
switch {
|
|
case on:
|
|
ui.Icon(c, icons.Must("check")).Size(14, 14)
|
|
case it.Icon != nil:
|
|
ui.Icon(c, it.Icon).Size(14, 14)
|
|
}
|
|
if it.Label != "" {
|
|
ui.Text(c, it.Label).SingleLine()
|
|
}
|
|
})
|
|
}
|