ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
50 lines
1.3 KiB
Go
50 lines
1.3 KiB
Go
package layout
|
|
|
|
import (
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
)
|
|
|
|
// AspectRatioOptions configure an AspectRatio.
|
|
type AspectRatioOptions struct {
|
|
// Ratio is width over height; zero is 1.
|
|
Ratio float32
|
|
}
|
|
|
|
// AspectRatio centers the largest Ratio frame that fits; the child is centered, not stretched.
|
|
func AspectRatio(c *ui.Context, opts AspectRatioOptions, child func()) ui.Element {
|
|
if opts.Ratio < 0 {
|
|
panic("mujica: AspectRatio Ratio must be positive")
|
|
}
|
|
if child == nil {
|
|
panic("mujica: AspectRatio needs a child")
|
|
}
|
|
r := opts.Ratio
|
|
if r == 0 {
|
|
r = 1
|
|
}
|
|
outer := ui.Box(c).Fill().Center()
|
|
room := outer.Bounds()
|
|
internal.Remeasure(c, outer, room.W, room.H)
|
|
return outer.Children(func() {
|
|
frame := ui.Box(c).AspectRatio(r).Shrink(0).Center().Clip()
|
|
was := frame.Bounds()
|
|
w := room.W
|
|
// A room whose height differs from the frame's, or a frame narrower than it, has a set height.
|
|
if room.H-was.H > 0.5 || was.H-room.H > 0.5 || was.W < room.W-0.5 {
|
|
w = min(w, room.H*r)
|
|
}
|
|
if w <= 0 {
|
|
// Not laid out yet: Remeasure rebuilds once the room is known.
|
|
frame.WidthPercent(100)
|
|
} else {
|
|
frame.Width(w)
|
|
if w-was.W > 0.5 || was.W-w > 0.5 {
|
|
c.Invalidate()
|
|
}
|
|
}
|
|
frame.Children(child)
|
|
})
|
|
}
|