ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
package overlay
|
|
|
|
import (
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// PopoverOptions configure a Popover.
|
|
type PopoverOptions struct {
|
|
// Title shows in serif at the top and names the panel.
|
|
Title string
|
|
// Width fixes the panel width; zero fits the content, at least the anchor's width.
|
|
Width float32
|
|
// Label names an untitled panel for assistive technology.
|
|
Label string
|
|
}
|
|
|
|
// Popover shows content below anchor, or above it, inside the window while *open is true.
|
|
func Popover(c *ui.Context, anchor ui.Element, open *bool, opts PopoverOptions, content func()) ui.Element {
|
|
if !anchor.Valid() {
|
|
panic("mujica: Popover needs an anchor")
|
|
}
|
|
if !*open {
|
|
return ui.Element{}
|
|
}
|
|
core.OverlayLayer(c, open)
|
|
u := core.Density(c).Unit()
|
|
b := anchor.Bounds()
|
|
label := opts.Label
|
|
if opts.Title != "" {
|
|
label = opts.Title
|
|
}
|
|
panel := ui.PopoverBase(c, anchor, open, func(panel ui.Element) {
|
|
core.OverlayStyle(c, panel, OverlayAnchored(c, panel, b))
|
|
panel.Margin(6, 0, 0, 0).Padding(u * 3).Gap(u * 2).MinWidth(PopoverWide(c, b.W)).MaxHeight(PopoverRoom(c, b)).Label(label)
|
|
if opts.Width > 0 {
|
|
panel.Width(PopoverWide(c, opts.Width))
|
|
} else {
|
|
panel.MaxWidth(PopoverWide(c, 360))
|
|
}
|
|
if opts.Title != "" {
|
|
ui.Text(c, opts.Title).Font(theme.SerifFont).FontSize(core.FontSize(c, theme.BodySize+2)).FontWeight(600).Shrink(0)
|
|
}
|
|
ui.Scroll(c).Shrink(1).Children(content)
|
|
})
|
|
if !*open {
|
|
slog.Debug("mujica: popover close")
|
|
}
|
|
return panel
|
|
}
|
|
|
|
// PopoverRoom is the tallest a panel below or above anchor b may be.
|
|
func PopoverRoom(c *ui.Context, b ui.Rect) float32 {
|
|
_, h := c.Size()
|
|
return max(b.Y, h-b.Y-b.H) - 16
|
|
}
|
|
|
|
// PopoverWide caps a panel width w to the window.
|
|
func PopoverWide(c *ui.Context, w float32) float32 {
|
|
ww, _ := c.Size()
|
|
return min(w, ww-8)
|
|
}
|