ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
97 lines
2.9 KiB
Go
97 lines
2.9 KiB
Go
package account
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/overlay"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// CoachmarkStep uses an anchor built in the current frame.
|
|
type CoachmarkStep struct {
|
|
Anchor ui.Element
|
|
Title, Body string
|
|
}
|
|
|
|
// CoachmarkResult reports tour completion or dismissal.
|
|
type CoachmarkResult struct {
|
|
Element ui.Element
|
|
finished, dismissed bool
|
|
}
|
|
|
|
// Finished reports Done on the last step.
|
|
func (r CoachmarkResult) Finished() bool { return r.finished }
|
|
|
|
// Dismissed reports Escape, a click outside or Skip.
|
|
func (r CoachmarkResult) Dismissed() bool { return r.dismissed }
|
|
|
|
// Coachmark provides anchored tips and keyboard-accessible step navigation.
|
|
func Coachmark(c *ui.Context, open *bool, step *int, steps []CoachmarkStep) CoachmarkResult {
|
|
if len(steps) == 0 || *step < 0 || *step >= len(steps) {
|
|
panic(fmt.Sprintf("mujica: Coachmark step %d outside %d steps", *step, len(steps)))
|
|
}
|
|
var r CoachmarkResult
|
|
if !*open {
|
|
return r
|
|
}
|
|
cur := steps[*step]
|
|
if !cur.Anchor.Valid() || cur.Title == "" {
|
|
panic("mujica: CoachmarkStep needs an Anchor and a Title")
|
|
}
|
|
if cur.Anchor.IsDisabled() {
|
|
*open = false
|
|
return r
|
|
}
|
|
k := core.Tokens(c)
|
|
d := core.Density(c)
|
|
if b := cur.Anchor.Bounds(); b.W > 0 {
|
|
const pad = 4
|
|
ui.Overlay(c, func() {
|
|
ui.Box(c).Absolute().Left(b.X-pad).Top(b.Y-pad).Size(b.W+2*pad, b.H+2*pad).PassThrough().Role(ui.RoleNone).
|
|
Border(2, k.AccentText).Radius(theme.CardRadius)
|
|
})
|
|
}
|
|
from := *step
|
|
r.Element = overlay.Popover(c, cur.Anchor, open, overlay.PopoverOptions{Title: cur.Title, Width: 300}, func() {
|
|
ui.Column(c).Gap(d.Unit() * 3).Children(func() {
|
|
if cur.Body != "" {
|
|
ui.Text(c, cur.Body)
|
|
}
|
|
ui.Row(c).Gap(d.Unit() * 2).AlignItems(ui.Center).Children(func() {
|
|
ui.Text(c, fmt.Sprintf(core.Msg(c, "coachmark.count"), *step+1, len(steps))).TextColor(k.TextMuted).
|
|
FontSize(core.FontSize(c, theme.CaptionSize)).Grow(1)
|
|
if *step < len(steps)-1 && input.Button(c, core.Msg(c, "coachmark.skip"), input.ButtonOptions{Variant: input.Ghost}).Clicked() {
|
|
*open, r.dismissed = false, true
|
|
}
|
|
if *step > 0 && input.Button(c, core.Msg(c, "coachmark.back"), input.ButtonOptions{Variant: input.Secondary}).Clicked() {
|
|
*step--
|
|
}
|
|
last := *step == len(steps)-1
|
|
next := core.Msg(c, "coachmark.next")
|
|
if last {
|
|
next = core.Msg(c, "coachmark.done")
|
|
}
|
|
if core.AutoFocus(c, input.Button(c, next, input.ButtonOptions{})).Clicked() {
|
|
if last {
|
|
*open, r.finished = false, true
|
|
} else {
|
|
*step++
|
|
}
|
|
}
|
|
})
|
|
})
|
|
})
|
|
if !*open && !r.finished {
|
|
r.dismissed = true
|
|
}
|
|
if *step != from || !*open {
|
|
slog.Debug("mujica: coachmark step", "step", *step, "open", *open)
|
|
}
|
|
return r
|
|
}
|