ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
82 lines
2.2 KiB
Go
82 lines
2.2 KiB
Go
package account
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
)
|
|
|
|
func coachmarkView(c *ui.Context, open *bool, step *int, r *CoachmarkResult) {
|
|
var a, b ui.Element
|
|
ui.Row(c).Gap(40).Padding(20).Children(func() {
|
|
a = input.Button(c, "Compose", input.ButtonOptions{})
|
|
b = input.Button(c, "Archive", input.ButtonOptions{Variant: input.Secondary})
|
|
})
|
|
*r = Coachmark(c, open, step, []CoachmarkStep{
|
|
{Anchor: a, Title: "Write here", Body: "Start a new letter."},
|
|
{Anchor: b, Title: "Keep it tidy", Body: "Archive finished threads."},
|
|
})
|
|
}
|
|
|
|
func TestCoachmarkStepsAndEscape(t *testing.T) {
|
|
open, step := true, 0
|
|
var r CoachmarkResult
|
|
done, dismissed := 0, 0
|
|
tt := accountTester(600, 400, func(c *ui.Context) {
|
|
coachmarkView(c, &open, &step, &r)
|
|
if r.Finished() {
|
|
done++
|
|
}
|
|
if r.Dismissed() {
|
|
dismissed++
|
|
}
|
|
})
|
|
tt.Frame()
|
|
if !tt.HasText("Write here") || !tt.HasText("1 of 2") {
|
|
t.Fatalf("first: %q", tt.Texts())
|
|
}
|
|
tt.Key(0, ui.KeyEnter)
|
|
if step != 1 || !tt.HasText("Keep it tidy") {
|
|
t.Fatalf("next: %d", step)
|
|
}
|
|
_ = tt.Click("Done")
|
|
if done != 1 || open {
|
|
t.Fatal("done not reported")
|
|
}
|
|
open, step = true, 0
|
|
tt.Frame()
|
|
tt.Key(0, ui.KeyEscape)
|
|
if open || dismissed != 1 || done != 1 {
|
|
t.Fatalf("escape: open %v dismissed %d", open, dismissed)
|
|
}
|
|
}
|
|
|
|
func TestCoachmarkSnapshot(t *testing.T) {
|
|
snapshot(t, "coachmark", 420, 230, func(c *ui.Context) {
|
|
open := ui.Local(c.Root(), "open", func() bool { return true })
|
|
step := ui.Local(c.Root(), "step", func() int { return 0 })
|
|
var r CoachmarkResult
|
|
coachmarkView(c, open, step, &r)
|
|
})
|
|
}
|
|
|
|
func TestCoachmarkDisabledAnchorCloses(t *testing.T) {
|
|
open, step, disabled := true, 0, false
|
|
tt := accountTester(600, 400, func(c *ui.Context) {
|
|
a := input.Button(c, "Compose", input.ButtonOptions{Disabled: disabled})
|
|
Coachmark(c, &open, &step, []CoachmarkStep{{Anchor: a, Title: "Write here"}})
|
|
})
|
|
disabled = true
|
|
tt.Frame()
|
|
if open || tt.HasText("Write here") {
|
|
t.Fatal("disabled anchor retains coachmark")
|
|
}
|
|
}
|
|
|
|
func TestCoachmarkInvalidStep(t *testing.T) {
|
|
open, step := true, 1
|
|
accountPanics(t, func(c *ui.Context) { Coachmark(c, &open, &step, []CoachmarkStep{{Title: "Only step"}}) })
|
|
}
|