ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
102 lines
3.2 KiB
Go
102 lines
3.2 KiB
Go
package account
|
|
|
|
import (
|
|
"log/slog"
|
|
"strings"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/icons"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
)
|
|
|
|
// LoginFormState holds the form; only OnSubmit sees the password.
|
|
type LoginFormState struct {
|
|
Account string
|
|
Remember bool
|
|
password string
|
|
tried bool
|
|
submitting bool
|
|
err string
|
|
}
|
|
|
|
// EndSubmit finishes a sign-in, shows err and wipes the password.
|
|
func (s *LoginFormState) EndSubmit(err string) {
|
|
if !s.submitting {
|
|
panic("mujica: LoginFormState.EndSubmit without a submit in progress")
|
|
}
|
|
s.submitting, s.err, s.password = false, err, ""
|
|
slog.Debug("mujica: login_form submit ended", "failed", err != "")
|
|
}
|
|
|
|
// LoginFormOptions configure a LoginForm. OnSubmit is required.
|
|
type LoginFormOptions struct {
|
|
// OnSubmit alone receives the credentials; then call EndSubmit.
|
|
OnSubmit func(account, password string, remember bool)
|
|
// AccountLabel replaces the built-in "Email or username".
|
|
AccountLabel string
|
|
Disabled bool
|
|
}
|
|
|
|
// LoginForm collects credentials; it never checks or stores them.
|
|
func LoginForm(c *ui.Context, s *LoginFormState, opts LoginFormOptions) ui.Element {
|
|
if opts.OnSubmit == nil {
|
|
panic("mujica: LoginForm needs OnSubmit")
|
|
}
|
|
k := core.Tokens(c)
|
|
d := core.Density(c)
|
|
accountLabel := opts.AccountLabel
|
|
if accountLabel == "" {
|
|
accountLabel = core.Msg(c, "login_form.account")
|
|
}
|
|
e := ui.Column(c).Gap(d.Unit() * 4).Width(340).Disabled(opts.Disabled)
|
|
disabled := e.IsDisabled()
|
|
missing := func(v string) string {
|
|
if s.tried && strings.TrimSpace(v) == "" {
|
|
return core.Msg(c, "form.required")
|
|
}
|
|
return ""
|
|
}
|
|
submit := false
|
|
var acc, pw input.InputResult
|
|
e.Children(func() {
|
|
input.FormField(c, accountLabel, input.FormFieldOptions{Required: true}, func() ui.Element {
|
|
acc = input.TextInput(c, &s.Account, input.TextInputOptions{Disabled: disabled || s.submitting, Error: missing(s.Account)})
|
|
return acc.Input
|
|
})
|
|
input.FormField(c, core.Msg(c, "login_form.password"), input.FormFieldOptions{Required: true}, func() ui.Element {
|
|
pw = input.PasswordInput(c, &s.password, input.PasswordInputOptions{Disabled: disabled || s.submitting, Error: missing(s.password)})
|
|
return pw.Input
|
|
})
|
|
if acc.Changed() || pw.Changed() {
|
|
s.err = ""
|
|
}
|
|
input.Checkbox(c, &s.Remember, core.Msg(c, "login_form.remember"), input.CheckboxOptions{Disabled: disabled || s.submitting})
|
|
if s.err != "" {
|
|
ui.Row(c).Gap(d.Unit() * 2).AlignItems(ui.Start).TextColor(k.Danger).Role(ui.RoleStatus).Children(func() {
|
|
ui.Icon(c, icons.Must("circle-alert")).Size(16, 16).Shrink(0)
|
|
ui.Text(c, s.err).Grow(1)
|
|
})
|
|
}
|
|
b := input.Button(c, core.Msg(c, "login_form.submit"), input.ButtonOptions{Loading: s.submitting, Disabled: disabled})
|
|
b.FillWidth()
|
|
submit = b.Clicked() || acc.Submitted() || pw.Submitted()
|
|
})
|
|
if submit && !disabled && !s.submitting {
|
|
s.tried = true
|
|
switch {
|
|
case strings.TrimSpace(s.Account) == "":
|
|
acc.Input.Focus()
|
|
return e
|
|
case s.password == "":
|
|
pw.Input.Focus()
|
|
return e
|
|
}
|
|
s.submitting, s.err = true, ""
|
|
slog.Debug("mujica: login_form submitted")
|
|
opts.OnSubmit(strings.TrimSpace(s.Account), s.password, s.Remember)
|
|
}
|
|
return e
|
|
}
|