ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
107 lines
3.9 KiB
Go
107 lines
3.9 KiB
Go
package account
|
|
|
|
import (
|
|
"log/slog"
|
|
"strings"
|
|
"unicode/utf8"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/display"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/internal"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// Profile is what a ProfileEditor edits.
|
|
type Profile struct {
|
|
Name, Bio string
|
|
}
|
|
|
|
// ProfileEditorOptions configure a ProfileEditor.
|
|
type ProfileEditorOptions struct {
|
|
// Saved is the baseline for detecting unsaved edits.
|
|
Saved Profile
|
|
// Avatar is the current picture; nil shows initials.
|
|
Avatar *ui.Bitmap
|
|
// BioLimit bounds the saved biography; zero means 160.
|
|
BioLimit int
|
|
// Saving shows the save in progress and blocks edits.
|
|
Saving bool
|
|
Disabled bool
|
|
}
|
|
|
|
// ProfileEditorResult reports save, avatar and discard requests.
|
|
type ProfileEditorResult struct {
|
|
Element ui.Element
|
|
save, avatar, reset bool
|
|
}
|
|
|
|
// Save reports a request to store the edited profile.
|
|
func (r ProfileEditorResult) Save() bool { return r.save }
|
|
|
|
// ChangeAvatar reports a request to pick a new picture.
|
|
func (r ProfileEditorResult) ChangeAvatar() bool { return r.avatar }
|
|
|
|
// Discarded reports that the edits went back to Saved.
|
|
func (r ProfileEditorResult) Discarded() bool { return r.reset }
|
|
|
|
// ProfileEditor edits name and biography, marking unsaved changes.
|
|
func ProfileEditor(c *ui.Context, p *Profile, opts ProfileEditorOptions) ProfileEditorResult {
|
|
if opts.BioLimit < 0 {
|
|
panic("mujica: ProfileEditor BioLimit cannot be negative")
|
|
}
|
|
limit := opts.BioLimit
|
|
if limit == 0 {
|
|
limit = 160
|
|
}
|
|
k := core.Tokens(c)
|
|
d := core.Density(c)
|
|
var r ProfileEditorResult
|
|
r.Element = ui.Column(c).Gap(d.Unit() * 4).Width(420).Disabled(opts.Disabled)
|
|
locked := r.Element.IsDisabled() || opts.Saving
|
|
dirty := *p != opts.Saved
|
|
nameErr := ""
|
|
if strings.TrimSpace(p.Name) == "" {
|
|
nameErr = core.Msg(c, "form.required")
|
|
}
|
|
r.Element.Children(func() {
|
|
ui.Row(c).Gap(d.Unit() * 4).AlignItems(ui.Center).Children(func() {
|
|
display.Avatar(c, p.Name, display.AvatarOptions{Image: opts.Avatar, Size: 64})
|
|
if input.Button(c, core.Msg(c, "profile_editor.avatar"), input.ButtonOptions{Variant: input.Secondary, Disabled: locked}).Clicked() && !locked {
|
|
r.avatar = true
|
|
}
|
|
})
|
|
input.FormField(c, core.Msg(c, "profile_editor.name"), input.FormFieldOptions{Required: true}, func() ui.Element {
|
|
return input.TextInput(c, &p.Name, input.TextInputOptions{Disabled: locked, Error: nameErr}).Input
|
|
})
|
|
input.FormField(c, core.Msg(c, "profile_editor.bio"), input.FormFieldOptions{}, func() ui.Element {
|
|
return input.TextArea(c, &p.Bio, input.TextAreaOptions{MaxLength: limit, Disabled: locked}).Input
|
|
})
|
|
ui.Row(c).Gap(d.Unit() * 3).AlignItems(ui.Center).Children(func() {
|
|
if dirty {
|
|
ui.Row(c).Gap(d.Unit()).AlignItems(ui.Center).Grow(1).Role(ui.RoleStatus).Children(func() {
|
|
ui.Box(c).Size(10, 10).Draw(func(pt *ui.Painter, rect ui.Rect) {
|
|
pt.FillPath(internal.Diamond(internal.Snap(pt, rect.X+5), internal.Snap(pt, rect.Y+5), 10), k.Warning)
|
|
})
|
|
ui.Text(c, core.Msg(c, "profile_editor.unsaved")).TextColor(k.Warning).FontSize(core.FontSize(c, theme.CaptionSize)).FontWeight(600)
|
|
})
|
|
} else {
|
|
ui.Box(c).Grow(1)
|
|
}
|
|
if input.Button(c, core.Msg(c, "profile_editor.discard"), input.ButtonOptions{Variant: input.Ghost, Disabled: locked || !dirty}).Clicked() && !locked {
|
|
*p, r.reset = opts.Saved, true
|
|
}
|
|
valid := strings.TrimSpace(p.Name) != "" && utf8.RuneCountInString(p.Bio) <= limit
|
|
if input.Button(c, core.Msg(c, "profile_editor.save"), input.ButtonOptions{Loading: opts.Saving, Disabled: r.Element.IsDisabled() || !dirty || !valid}).Clicked() && !locked && valid {
|
|
r.save = true
|
|
}
|
|
})
|
|
})
|
|
if r.save || r.reset || r.avatar {
|
|
slog.Debug("mujica: profile_editor action", "save", r.save, "discard", r.reset, "avatar", r.avatar)
|
|
}
|
|
return r
|
|
}
|