ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
69 lines
2.1 KiB
Go
69 lines
2.1 KiB
Go
package agent
|
|
|
|
import (
|
|
"log/slog"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/input"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/overlay"
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/theme"
|
|
)
|
|
|
|
// ToolApprovalOptions configure a ToolApprovalDialog. Tool is required.
|
|
type ToolApprovalOptions struct {
|
|
Tool string
|
|
// Args is the call's arguments, JSON when valid.
|
|
Args string
|
|
// Reason says why the agent wants to run the tool.
|
|
Reason string
|
|
}
|
|
|
|
// ToolApprovalResult reports the choice made in this frame.
|
|
type ToolApprovalResult struct {
|
|
Element ui.Element
|
|
Allowed bool
|
|
Denied bool
|
|
}
|
|
|
|
// ToolApprovalDialog asks to approve a tool call; Deny has focus.
|
|
func ToolApprovalDialog(c *ui.Context, open *bool, opts ToolApprovalOptions) ToolApprovalResult {
|
|
if opts.Tool == "" {
|
|
panic("mujica: ToolApprovalDialog needs a Tool")
|
|
}
|
|
var r ToolApprovalResult
|
|
was := *open
|
|
u := core.Density(c).Unit()
|
|
r.Element = overlay.Dialog(c, open, overlay.DialogOptions{
|
|
Title: core.Msg(c, "tool_approval_dialog.title"), Description: opts.Reason, KeepOnBackdrop: true, HideClose: true,
|
|
Actions: func() {
|
|
// Deny first: a reflexive Enter never runs the tool.
|
|
if core.AutoFocus(c, input.Button(c, core.Msg(c, "tool_approval_dialog.deny"), input.ButtonOptions{Variant: input.Secondary})).Clicked() {
|
|
r.Denied = true
|
|
}
|
|
if input.Button(c, core.Msg(c, "tool_approval_dialog.allow"), input.ButtonOptions{}).Clicked() {
|
|
r.Allowed = true
|
|
}
|
|
},
|
|
}, func() {
|
|
ui.Column(c).Gap(u * 2).Children(func() {
|
|
ui.Row(c).Gap(u * 2).AlignItems(ui.Center).Children(func() {
|
|
AgentCaption(c, core.Msg(c, "tool_approval_dialog.tool"))
|
|
ui.Text(c, opts.Tool).Font(theme.MonoFont).FontWeight(600)
|
|
})
|
|
if opts.Args != "" {
|
|
AgentCode(c, "json", agentPrettyJSON(opts.Args), 260)
|
|
}
|
|
})
|
|
})
|
|
if was && !*open && !r.Allowed {
|
|
r.Denied = true // Escape
|
|
}
|
|
if r.Allowed || r.Denied {
|
|
slog.Debug("mujica: tool_approval_dialog choose", "tool", opts.Tool, "allowed", r.Allowed)
|
|
*open = false
|
|
}
|
|
return r
|
|
}
|