ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
55 lines
1.8 KiB
Go
55 lines
1.8 KiB
Go
package chart
|
|
|
|
import (
|
|
"math"
|
|
"testing"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
)
|
|
|
|
func TestAreaBands(t *testing.T) {
|
|
series := []ChartSeries{{Name: "a", Values: []float64{1, math.NaN(), 3}}, {Name: "b", Values: []float64{2, 2, 2}}}
|
|
none := func(string) bool { return false }
|
|
st := areaBands(series, none, true, 10)
|
|
if st[0][0][0] != 11 || st[1][1][0] != 11 || st[0][1][0] != 13 || !math.IsNaN(st[0][0][1]) || st[0][1][1] != 12 {
|
|
t.Fatalf("stacked %v", st)
|
|
}
|
|
hideA := func(s string) bool { return s == "a" }
|
|
st = areaBands(series, hideA, true, 0)
|
|
if st[0][1][2] != 2 || st[1][1][2] != 0 {
|
|
t.Fatalf("hidden series still stacked: %v", st)
|
|
}
|
|
flat := areaBands(series, none, false, -1)
|
|
if flat[0][0][2] != 3 || flat[1][0][2] != -1 || flat[1][1][2] != -1 {
|
|
t.Fatalf("baseline %v", flat)
|
|
}
|
|
}
|
|
|
|
func TestAreaChartStackedReadout(t *testing.T) {
|
|
h := &chartHarness{build: func(c *ui.Context) ChartResult {
|
|
return AreaChart(c, lineSeries(), AreaChartOptions{Frame: ChartFrame{Label: "Nave"}, Stacked: true, Baseline: 1})
|
|
}}
|
|
tt := ui.NewTester(h.view, 520, 420)
|
|
tabTo(t, tt, "Nave")
|
|
tt.Key(0, ui.KeyRight)
|
|
if got := chartReadout(tt); got != "0 · Pews 3 · Candles 5" {
|
|
t.Fatalf("readout shows the series values, not the stack: %q", got)
|
|
}
|
|
b := h.box(tt)
|
|
tt.Move(b.X+52+(b.W-64)*0.5, b.Y+b.H/2)
|
|
if got := chartReadout(tt); got != "2 · Pews no value · Candles 6" || h.res.Point != 2 {
|
|
t.Fatalf("hover %q", got)
|
|
}
|
|
}
|
|
|
|
func TestAreaChartSnapshot(t *testing.T) {
|
|
snapshot(t, "area_chart", 520, 340, func(c *ui.Context) {
|
|
ui.Column(c).Padding(16).Children(func() {
|
|
AreaChart(c, []ChartSeries{
|
|
{Name: "Matins", Values: []float64{3, 4, 6, 5, 7, 8}},
|
|
{Name: "Vespers", Values: []float64{2, 3, 2, 4, 3, 5}},
|
|
}, AreaChartOptions{Frame: ChartFrame{Label: "Attendance"}, Stacked: true})
|
|
})
|
|
})
|
|
}
|