ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
74 lines
2.0 KiB
Go
74 lines
2.0 KiB
Go
package chart
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
var radarAxes = []string{"Voice", "Latin", "Chant", "Organ", "Bells"}
|
|
|
|
func radarSeries() []ChartSeries {
|
|
return []ChartSeries{
|
|
{Name: "Agnès", Values: []float64{8, 6, 9, 4, 7}},
|
|
{Name: "Clare", Values: []float64{5, 9, 6, 8, 3}},
|
|
}
|
|
}
|
|
|
|
func TestRadarChartReadout(t *testing.T) {
|
|
h := &chartHarness{build: func(c *ui.Context) ChartResult {
|
|
return RadarChart(c, radarAxes, radarSeries(), RadarChartOptions{Frame: ChartFrame{Label: "Skills"}})
|
|
}}
|
|
tt := ui.NewTester(h.view, 520, 420)
|
|
tabTo(t, tt, "Skills")
|
|
tt.Key(0, ui.KeyRight)
|
|
tt.Key(0, ui.KeyRight)
|
|
if got := chartReadout(tt); got != "Latin · Agnès 6 · Clare 9" {
|
|
t.Fatalf("readout %q", got)
|
|
}
|
|
b := h.box(tt)
|
|
cx, cy := b.X+b.W/2, b.Y+38+120+4
|
|
tt.Key(0, ui.KeyEscape)
|
|
tt.Move(cx, cy-60) // straight up: the first axis
|
|
if got := chartReadout(tt); got != "Voice · Agnès 8 · Clare 5" {
|
|
t.Fatalf("hover %q", got)
|
|
}
|
|
if err := tt.Click("Clare"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
tt.Move(cx, cy-60)
|
|
if got := chartReadout(tt); got != "Voice · Agnès 8" {
|
|
t.Fatalf("hidden series read: %q", got)
|
|
}
|
|
}
|
|
|
|
func TestRadarChartBad(t *testing.T) {
|
|
for name, build := range map[string]func(c *ui.Context){
|
|
"two axes": func(c *ui.Context) {
|
|
RadarChart(c, radarAxes[:2], nil, RadarChartOptions{Frame: ChartFrame{Label: "x"}})
|
|
},
|
|
"negative": func(c *ui.Context) {
|
|
RadarChart(c, radarAxes[:3], []ChartSeries{{Name: "a", Values: []float64{1, -1, 2}}}, RadarChartOptions{Frame: ChartFrame{Label: "x"}})
|
|
},
|
|
} {
|
|
func() {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Errorf("%s: no panic", name)
|
|
}
|
|
}()
|
|
ui.NewTester(func(c *ui.Context) { core.Use(c, core.Settings{}); build(c) }, 300, 300)
|
|
}()
|
|
}
|
|
}
|
|
|
|
func TestRadarChartSnapshot(t *testing.T) {
|
|
snapshot(t, "radar_chart", 520, 340, func(c *ui.Context) {
|
|
ui.Column(c).Padding(16).Children(func() {
|
|
RadarChart(c, radarAxes, radarSeries(), RadarChartOptions{Frame: ChartFrame{Label: "Skills"}})
|
|
})
|
|
})
|
|
}
|