ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
51 lines
1.5 KiB
Go
51 lines
1.5 KiB
Go
package chat
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
)
|
|
|
|
func TestThinkingIndicatorPhase(t *testing.T) {
|
|
tt := chatTester(400, 100, func(c *ui.Context) { ThinkingIndicator(c, ThinkingIndicatorOptions{}) })
|
|
if !tt.HasText("Thinking") {
|
|
t.Fatalf("texts %q", tt.Texts())
|
|
}
|
|
tt = chatTester(400, 100, func(c *ui.Context) {
|
|
ThinkingIndicator(c, ThinkingIndicatorOptions{Phase: "Reading the archives"})
|
|
})
|
|
if !tt.HasText("Reading the archives") {
|
|
t.Fatalf("texts %q", tt.Texts())
|
|
}
|
|
}
|
|
|
|
func TestThinkingIndicatorReducedMotionIsStill(t *testing.T) {
|
|
frame := func(reduce bool, at time.Duration) []byte {
|
|
tt := chatTester(200, 60, func(c *ui.Context) { ThinkingIndicator(c, ThinkingIndicatorOptions{}) })
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: reduce, TextScale: 1})
|
|
tt.Frame()
|
|
if at > 0 {
|
|
tt.Advance(at)
|
|
}
|
|
return encode(t, tt.Image())
|
|
}
|
|
if !bytes.Equal(frame(true, 0), frame(true, 300*time.Millisecond)) {
|
|
t.Fatal("reduced motion still moves")
|
|
}
|
|
tt := chatTester(200, 60, func(c *ui.Context) { ThinkingIndicator(c, ThinkingIndicatorOptions{}) })
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
if !tt.HasText("Thinking…") {
|
|
t.Fatalf("static label missing: %q", tt.Texts())
|
|
}
|
|
}
|
|
|
|
func TestThinkingIndicatorSnapshot(t *testing.T) {
|
|
snapshot(t, "thinking_indicator", 360, 70, func(c *ui.Context) {
|
|
ui.Column(c).Padding(16).Children(func() {
|
|
ThinkingIndicator(c, ThinkingIndicatorOptions{Phase: "Searching the archives"})
|
|
})
|
|
})
|
|
}
|