ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
88 lines
2.4 KiB
Go
88 lines
2.4 KiB
Go
package feedback
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
func TestBlinkHighlightFlashesOnceWithDirection(t *testing.T) {
|
|
value := 10.0
|
|
tt, n := motionFrames(func(c *ui.Context) {
|
|
BlinkHighlight(c, value, BlinkHighlightOptions{Duration: 200 * time.Millisecond})
|
|
}, 200, 60)
|
|
if motionBusy(tt, n) {
|
|
t.Fatal("first value flashed")
|
|
}
|
|
if _, ok := tt.Find("10.00"); !ok {
|
|
t.Fatal("value not named")
|
|
}
|
|
value = 12
|
|
tt.Frame()
|
|
a := encode(t, tt.Image())
|
|
if _, ok := tt.Find("12.00, up"); !ok {
|
|
t.Fatalf("direction not named: %q", tt.Texts())
|
|
}
|
|
tt.Advance(250 * time.Millisecond)
|
|
if bytes.Equal(a, encode(t, tt.Image())) || motionBusy(tt, n) {
|
|
t.Fatal("flash did not fade and stop")
|
|
}
|
|
value = 9
|
|
tt.Frame()
|
|
if _, ok := tt.Find("9.00, down"); !ok {
|
|
t.Fatalf("down not named: %q", tt.Texts())
|
|
}
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
value = 11
|
|
tt.Frame()
|
|
if motionBusy(tt, n) {
|
|
t.Fatal("flash under reduced motion")
|
|
}
|
|
if _, ok := tt.Find("11.00, up"); !ok {
|
|
t.Fatal("static mark missing under reduced motion")
|
|
}
|
|
}
|
|
|
|
func TestBlinkHighlightInvalid(t *testing.T) {
|
|
defer func() {
|
|
if recover() == nil {
|
|
t.Fatal("no panic")
|
|
}
|
|
}()
|
|
ui.Render(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
BlinkHighlight(c, 1, BlinkHighlightOptions{Duration: -1})
|
|
}, 100, 50, 1)
|
|
}
|
|
|
|
func TestBlinkHighlightSnapshot(t *testing.T) {
|
|
snapshotAfter(t, "blink_highlight", 300, 100, func(c *ui.Context) {
|
|
v := ui.Local(c.Root(), "v", func() float64 { return 101.5 })
|
|
w := ui.Local(c.Root(), "w", func() float64 { return 88.25 })
|
|
ui.Column(c).Padding(16).Gap(8).AlignItems(ui.Start).Children(func() {
|
|
BlinkHighlight(c, *v, BlinkHighlightOptions{})
|
|
BlinkHighlight(c, *w, BlinkHighlightOptions{})
|
|
})
|
|
*v, *w = 103.75, 86.5
|
|
}, func(tt *ui.Tester) { tt.Frame() })
|
|
}
|
|
|
|
func TestBlinkHighlightRestoredMotionKeepsStaticMark(t *testing.T) {
|
|
value := 1.0
|
|
tt, n := motionFrames(func(c *ui.Context) { BlinkHighlight(c, value, BlinkHighlightOptions{Duration: 5 * time.Second}) }, 300, 100)
|
|
value = 2
|
|
tt.Frame()
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
tt.SetPreferences(ui.Preferences{TextScale: 1})
|
|
if motionBusy(tt, n) {
|
|
t.Fatal("old highlight replayed after restoring motion")
|
|
}
|
|
if _, ok := tt.Find("2.00, up"); !ok {
|
|
t.Fatal("direction mark lost")
|
|
}
|
|
}
|