ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
79 lines
2.0 KiB
Go
79 lines
2.0 KiB
Go
package input
|
|
|
|
import (
|
|
"bytes"
|
|
"slices"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
func TestSpinnerLabelAndSize(t *testing.T) {
|
|
var mark ui.Rect
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{Locale: core.ZhCN})
|
|
core.Spinner(c, core.SpinnerOptions{})
|
|
core.Spinner(c, core.SpinnerOptions{Size: 32, Label: "Fetching mail", ShowLabel: true})
|
|
}, 400, 300)
|
|
r, ok := tt.Find("加载中")
|
|
if !ok || r.W != 16 || r.H != 16 {
|
|
t.Fatalf("default mark %v %v", r, ok)
|
|
}
|
|
if n := len(slices.DeleteFunc(tt.Texts(), func(s string) bool { return s != "加载中" })); n != 1 {
|
|
t.Fatalf("hidden label painted: %d", n)
|
|
}
|
|
mark, ok = tt.Find("Fetching mail")
|
|
if !ok || mark.W != 32 {
|
|
t.Fatalf("sized mark %v %v", mark, ok)
|
|
}
|
|
n := 0
|
|
for _, s := range tt.Texts() {
|
|
if s == "Fetching mail" {
|
|
n++
|
|
}
|
|
}
|
|
if n != 2 {
|
|
t.Fatalf("label as name and text: %d of %q", n, tt.Texts())
|
|
}
|
|
}
|
|
|
|
func TestSpinnerMotion(t *testing.T) {
|
|
show := true
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
if show {
|
|
core.Spinner(c, core.SpinnerOptions{Size: 40})
|
|
}
|
|
}, 100, 100)
|
|
a := encode(t, tt.Image())
|
|
tt.Advance(150 * time.Millisecond)
|
|
if bytes.Equal(a, encode(t, tt.Image())) {
|
|
t.Fatal("spinner did not turn")
|
|
}
|
|
tt.SetPreferences(ui.Preferences{ReduceMotion: true, TextScale: 1})
|
|
a = encode(t, tt.Image())
|
|
tt.Advance(150 * time.Millisecond)
|
|
if !bytes.Equal(a, encode(t, tt.Image())) {
|
|
t.Fatal("spinner turned under reduced motion")
|
|
}
|
|
show = false
|
|
tt.Frame()
|
|
if _, ok := tt.Find("Loading"); ok {
|
|
t.Fatal("hidden spinner still built")
|
|
}
|
|
}
|
|
|
|
func TestSpinnerSnapshot(t *testing.T) {
|
|
snapshot(t, "spinner", 360, 100, func(c *ui.Context) {
|
|
ui.Row(c).Padding(24).Gap(24).AlignItems(ui.Center).Children(func() {
|
|
core.Spinner(c, core.SpinnerOptions{})
|
|
core.Spinner(c, core.SpinnerOptions{Size: 24})
|
|
core.Spinner(c, core.SpinnerOptions{Size: 20, Label: "Syncing", ShowLabel: true})
|
|
Button(c, "Saving", ButtonOptions{Loading: true})
|
|
})
|
|
})
|
|
}
|