ZacharyZhang-NYandClaude Opus 5.5
bcce34cda1
MyGo v0.5.5 returns ui.Element as a checked value handle instead of a
pointer. Migrated with `mygo migrate-ui`, then fixed what the codemod
leaves to review:
- Element nil checks become .Valid(); absent elements are ui.Element{}.
- Input handlers and paint callbacks run outside the build pass, where
elements expire and Context methods are inert: read IsDisabled into a
local during the build, keep a ui.Handle for Focus, use c.Services()
for clipboard access, create ui.Local state during the build.
- Add core.AutoFocus: v0.5.5 records an overlay's opener after its
content builds, so same-frame autofocus lost focus restore on close.
It focuses one frame later; cascader rows defer their focus likewise.
- core.OverlayLayer identifies build passes by the root element, not
c.Now(), which repeats across passes and under the Tester clock.
- Context menus survive the opening press counted as PressedOutside;
split button tooltip no longer reorders its open menu; disabled
menubar rows pass presses to the panel; Form defers blur-started
async checks so the growing message no longer moves Submit away
from the release; Combobox drops its disabled copy now that MyGo
blocks typing under a disabled wrapper (canary flipped to a guard).
- The Tester clock is virtual: tests use Advance/Now instead of
time.Sleep/time.Now and read element state inside the view. The web
mirror advances the clock to wall time before each frame and input.
- AGENTS.md and docs describe the value Element API and the new pin.
Snapshot goldens are darwin-only and were not re-verified here.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
66 lines
1.6 KiB
Go
66 lines
1.6 KiB
Go
package input
|
|
|
|
import (
|
|
"slices"
|
|
"testing"
|
|
|
|
"github.com/egoist/mygo/ui"
|
|
|
|
"git.zacharyzhang.com/ZacharyZhang-NY/MujicaUI/core"
|
|
)
|
|
|
|
func TestFormFocusFollowsFieldAfterReorder(t *testing.T) {
|
|
var st FormState
|
|
first, second := "", ""
|
|
swapped := false
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
Form(c, &st, FormOptions{}, func(f *FormScope) {
|
|
fields := []func(){
|
|
func() {
|
|
FormItem(c, f, "first", &first, FormItemOptions[string]{Label: "First"}, func() ui.Element {
|
|
return TextInput(c, &first, TextInputOptions{Label: "First"}).Input
|
|
})
|
|
},
|
|
func() {
|
|
FormItem(c, f, "second", &second, FormItemOptions[string]{Label: "Second"}, func() ui.Element {
|
|
return TextInput(c, &second, TextInputOptions{Label: "Second"}).Input
|
|
})
|
|
},
|
|
}
|
|
if swapped {
|
|
slices.Reverse(fields)
|
|
}
|
|
for _, fn := range fields {
|
|
fn()
|
|
}
|
|
})
|
|
}, 500, 400)
|
|
if err := tt.Click("First"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
tt.Type("a")
|
|
swapped = true
|
|
tt.Frame()
|
|
tt.Type("b")
|
|
if first != "ab" || second != "" {
|
|
t.Fatalf("first %q second %q, want typing to stay in First", first, second)
|
|
}
|
|
}
|
|
|
|
func TestToggleGroupFocusFollowsValueAfterReorder(t *testing.T) {
|
|
var on []string
|
|
items := []ToggleItem[string]{{Value: "left", Label: "Left"}, {Value: "right", Label: "Right"}}
|
|
tt := ui.NewTester(func(c *ui.Context) {
|
|
core.Use(c, core.Settings{})
|
|
ToggleGroup(c, &on, items, ToggleGroupOptions{Multiple: true, Label: "Align"})
|
|
}, 400, 200)
|
|
tt.Key(0, ui.KeyTab)
|
|
slices.Reverse(items)
|
|
tt.Frame()
|
|
tt.Key(0, ui.KeySpace)
|
|
if !slices.Equal(on, []string{"left"}) {
|
|
t.Fatalf("pressed %v, want [left]", on)
|
|
}
|
|
}
|